From: Linus Torvalds <torvalds@linux-foundation.org>
To: Ingo Molnar <mingo@elte.hu>
Cc: Christoph Lameter <clameter@sgi.com>,
Michal Piotrowski <michal.k.k.piotrowski@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>,
"Cherwin R. Nooitmeer" <cherwin@gmail.com>,
linux-pcmcia@lists.infradead.org,
Robert de Rooy <robert.de.rooy@gmail.com>,
Alan Cox <alan@redhat.com>, Tejun Heo <htejun@gmail.com>,
sparclinux@vger.kernel.org, David Miller <davem@davemloft.net>,
Mikael Pettersson <mikpe@it.uu.se>,
linux1394-devel@lists.sourceforge.net,
Stefan Richter <stefanr@s5r6.in-berlin.de>,
Kristian H?gsberg <krh@bitplanet.net>,
linux-pm@lists.linux-foundation.org,
"Rafael J. Wysocki" <rjw@sisk.pl>, Pavel Machek <pavel@ucw.cz>,
Marcus Better <marcus@better.se>,
Andrey Borzenkov <arvidjaar@mail.ru>,
linux-usb-devel@lists.sourceforge.net,
Greg Kroah-Hartman <gregkh@suse.de>
Subject: Re: [2/3] 2.6.22-rc2: known regressions v2
Date: Thu, 24 May 2007 12:50:22 -0700 (PDT) [thread overview]
Message-ID: <alpine.LFD.0.98.0705241247540.26602@woody.linux-foundation.org> (raw)
In-Reply-To: <20070524193740.GA6787@elte.hu>
On Thu, 24 May 2007, Ingo Molnar wrote:
>
> i very much agree that this kmalloc_index() one shouldnt be called a
> "BUG: ", but if you look at the majority of WARN_ON() instances they are
> checks for clear, serious kernel bugs.
I _still_ disagree.
There's a huge difference between "You killed my father, prepare to die",
and "Btw, I didn't like that, but I'll just continue".
And that's the difference between BUG_ON() and WARN_ON().
And dammit, the kernel message should make that CLEAR. It's totally
idiotic to call both "BUG". One is a clear BUG, the other is a "uhhuh,
something unexpected happened, but I know how to continue".
So stop this idiotic "we should call them both the same". If they actually
were the same, they'd both be called BUG_ON().
Linus
next prev parent reply other threads:[~2007-05-24 19:51 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <46558708.2040803@googlemail.com>
2007-05-24 14:04 ` Michal Piotrowski
2007-05-24 14:18 ` [linux-pm] " Alan Stern
2007-05-24 17:01 ` Christoph Lameter
2007-05-24 17:12 ` Linus Torvalds
2007-05-24 17:18 ` Christoph Lameter
2007-05-24 18:49 ` Andrew Morton
2007-05-24 19:21 ` Linus Torvalds
2007-05-24 21:02 ` Jeff Garzik
2007-05-24 19:37 ` Ingo Molnar
2007-05-24 19:50 ` Linus Torvalds [this message]
2007-05-24 20:02 ` David Woodhouse
2007-05-25 10:11 ` Ingo Molnar
2007-05-25 10:18 ` Stefan Richter
2007-05-25 16:21 ` Linus Torvalds
2007-05-25 11:53 ` Chris Newport
2007-05-25 12:34 ` Ingo Molnar
2007-05-25 16:33 ` Andrew Morton
2007-05-25 16:45 ` Christoph Lameter
2007-05-28 3:46 ` Vivek Goyal
2007-05-25 12:40 ` Stefan Richter
2007-05-25 16:45 ` Linus Torvalds
2007-05-25 17:03 ` Alan Cox
2007-05-25 17:19 ` Linus Torvalds
2007-05-25 17:37 ` Andrew Morton
2007-05-25 17:48 ` Alan Cox
2007-05-25 17:50 ` Linus Torvalds
2007-05-28 4:27 ` Vivek Goyal
2007-05-25 17:07 ` Chuck Ebbert
2007-05-25 17:21 ` Linus Torvalds
2007-05-25 18:03 ` Chris Newport
2007-05-25 20:36 ` David Miller
2007-05-26 13:16 ` [linux-pm] " Matt Sealey
2007-06-03 6:47 ` Stefan Richter
2007-05-24 14:04 ` [3/3] " Michal Piotrowski
2007-05-24 22:04 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.0.98.0705241247540.26602@woody.linux-foundation.org \
--to=torvalds@linux-foundation.org \
--cc=akpm@linux-foundation.org \
--cc=alan@redhat.com \
--cc=arvidjaar@mail.ru \
--cc=cherwin@gmail.com \
--cc=clameter@sgi.com \
--cc=davem@davemloft.net \
--cc=gregkh@suse.de \
--cc=htejun@gmail.com \
--cc=krh@bitplanet.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pcmcia@lists.infradead.org \
--cc=linux-pm@lists.linux-foundation.org \
--cc=linux-usb-devel@lists.sourceforge.net \
--cc=linux1394-devel@lists.sourceforge.net \
--cc=marcus@better.se \
--cc=michal.k.k.piotrowski@gmail.com \
--cc=mikpe@it.uu.se \
--cc=mingo@elte.hu \
--cc=pavel@ucw.cz \
--cc=rjw@sisk.pl \
--cc=robert.de.rooy@gmail.com \
--cc=sparclinux@vger.kernel.org \
--cc=stefanr@s5r6.in-berlin.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®