From: Linus Torvalds <torvalds@linux-foundation.org>
To: Christoph Lameter <clameter@sgi.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Jeremy Fitzhardinge <jeremy@goop.org>,
Srinivasa Ds <srinivasa@in.ibm.com>,
linux-kernel@vger.kernel.org,
Srivatsa Vaddagiri <vatsa@in.ibm.com>,
Dinakar Guniguntala <dino@in.ibm.com>,
pj@sgi.com, simon.derr@bull.net, clameter@cthulhu.engr.sgi.com,
rientjes@google.com
Subject: Re: [RFC] [PATCH] cpuset operations causes Badness at mm/slab.c:777 warning
Date: Fri, 1 Jun 2007 16:41:19 -0700 (PDT) [thread overview]
Message-ID: <alpine.LFD.0.98.0706011638360.3957@woody.linux-foundation.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0706011617330.9781@schroedinger.engr.sgi.com>
On Fri, 1 Jun 2007, Christoph Lameter wrote:
>
> Something like this? (Not tested yet just for review):
I'm not seeing the path on the freeing side that silently accepts BADPTR.
It is not ok to derefence BADPTR, but it's obviously ok to _free_ it.
Also, if I read the patch correctly, you _also_ return BADPTR for slabs
that are too large. No? That would be wrong - those need to return NULL
for "out of memory".
(But I only looked at the diff, not at the end result, so it may be that
all the cases where you changed "return NULL" into "return BADPTR" were
really just the size-zero ones - it just looked suspicious).
Linus
next prev parent reply other threads:[~2007-06-01 23:42 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-01 7:27 Srinivasa Ds
2007-06-01 10:50 ` Srinivasa Ds
2007-06-01 18:13 ` Christoph Lameter
2007-06-01 19:11 ` Paul Jackson
2007-06-01 19:18 ` Christoph Lameter
2007-06-01 19:47 ` Paul Jackson
2007-06-01 19:51 ` Christoph Lameter
2007-06-01 20:02 ` Paul Jackson
2007-06-01 20:06 ` Christoph Lameter
2007-06-01 20:19 ` Paul Jackson
2007-06-01 20:43 ` Christoph Lameter
2007-06-01 20:54 ` Paul Jackson
2007-06-01 20:30 ` Jeremy Fitzhardinge
2007-06-01 20:44 ` Paul Jackson
2007-06-01 20:47 ` Christoph Lameter
2007-06-01 20:56 ` Jeremy Fitzhardinge
2007-06-01 20:59 ` Andrew Morton
2007-06-01 21:45 ` Christoph Lameter
2007-06-01 22:16 ` Andrew Morton
2007-06-01 22:20 ` Christoph Lameter
2007-06-01 22:33 ` Andrew Morton
2007-06-01 22:41 ` Christoph Lameter
2007-06-01 23:00 ` Linus Torvalds
2007-06-01 23:29 ` Christoph Lameter
2007-06-01 23:41 ` Linus Torvalds [this message]
2007-06-01 23:46 ` Christoph Lameter
2007-06-01 23:57 ` Linus Torvalds
2007-06-02 0:12 ` Christoph Lameter
2007-06-02 0:16 ` Andrew Morton
2007-06-02 0:26 ` Christoph Lameter
2007-06-02 1:04 ` Linus Torvalds
2007-06-02 0:46 ` Jeremy Fitzhardinge
2007-06-02 1:05 ` Valdis.Kletnieks
2007-06-02 1:24 ` Christoph Lameter
2007-06-01 23:02 ` Andrew Morton
2007-06-01 23:16 ` Christoph Lameter
2007-06-01 23:21 ` Christoph Lameter
2007-06-01 23:36 ` Linus Torvalds
2007-06-01 23:42 ` Christoph Lameter
2007-06-01 23:25 ` Linus Torvalds
2007-06-02 0:41 ` Jeremy Fitzhardinge
2007-06-02 0:43 ` Jeremy Fitzhardinge
2007-06-02 0:51 ` Andrew Morton
2007-06-02 0:59 ` Jeremy Fitzhardinge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.0.98.0706011638360.3957@woody.linux-foundation.org \
--to=torvalds@linux-foundation.org \
--cc=akpm@linux-foundation.org \
--cc=clameter@cthulhu.engr.sgi.com \
--cc=clameter@sgi.com \
--cc=dino@in.ibm.com \
--cc=jeremy@goop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pj@sgi.com \
--cc=rientjes@google.com \
--cc=simon.derr@bull.net \
--cc=srinivasa@in.ibm.com \
--cc=vatsa@in.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®