From: Linus Torvalds <torvalds@linux-foundation.org>
To: Etienne Lorrain <etienne_lorrain@yahoo.fr>
Cc: "H. Peter Anvin" <hpa@zytor.com>,
Chuck Ebbert <cebbert@redhat.com>,
linux-kernel@vger.kernel.org
Subject: Re: RE : Re: x86 setup code rewrite in C - revised
Date: Fri, 13 Jul 2007 16:09:24 -0700 (PDT) [thread overview]
Message-ID: <alpine.LFD.0.999.0707131609040.20061@woody.linux-foundation.org> (raw)
In-Reply-To: <700342.61011.qm@web26915.mail.ukl.yahoo.com>
On Fri, 13 Jul 2007, Etienne Lorrain wrote:
>
> > >> Also, I do not know if "m" is right in here:
> > >> static inline u8 rdfs8(addr_t addr)
> > >> {
> > >> u8 v;
> > >> asm("movb %%fs:%1,%0" : "=r" (v) : "m" (*(u8 *)addr));
> > >> return v;
> > >> }
> >
> > The "m" is correct right there.
>
> strange, "g" would mean anything can go there - and this assembly instruction
> should accept every access modes.
No it damn well should NOT.
the %fs: override works only with memory ops. End of story.
Linus
next prev parent reply other threads:[~2007-07-13 23:09 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-13 14:25 Etienne Lorrain
2007-07-13 16:35 ` Chuck Ebbert
2007-07-13 16:51 ` H. Peter Anvin
2007-07-13 20:10 ` RE : " Etienne Lorrain
2007-07-13 21:19 ` H. Peter Anvin
2007-07-16 9:02 ` RE : " Etienne Lorrain
2007-07-16 9:15 ` H. Peter Anvin
2007-07-16 10:21 ` Etienne Lorrain
2007-07-13 23:09 ` Linus Torvalds [this message]
2007-07-13 22:23 ` H. Peter Anvin
2007-07-16 13:31 ` Etienne Lorrain
2007-07-16 17:35 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.0.999.0707131609040.20061@woody.linux-foundation.org \
--to=torvalds@linux-foundation.org \
--cc=cebbert@redhat.com \
--cc=etienne_lorrain@yahoo.fr \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®