mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Linus Torvalds <torvalds@linux-foundation.org>
To: Eric Van Hensbergen <ericvh@gmail.com>
Cc: V9FS Developers <v9fs-developer@lists.sourceforge.net>,
	Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [GIT PULL] 9p Patches for 2.6.23 merge window
Date: Sun, 15 Jul 2007 16:49:33 -0700 (PDT)	[thread overview]
Message-ID: <alpine.LFD.0.999.0707151645561.20061@woody.linux-foundation.org> (raw)
In-Reply-To: <a4e6962a0707141320p376e51fcp4b1ceb681960e303@mail.gmail.com>



On Sat, 14 Jul 2007, Eric Van Hensbergen wrote:
> 
> The bulk of the changes were in the reorganization patch which mostly
> moved files and interfaces around in preparation for work on an
> in-kernel 9p server.

Please use "git diff -C --stat --summary" to generate the diffstat 
summary.

In particular, because you didn't use -C (or -M), git have you an 
old-style diffstat without renames, so the diffstat doesn't show that a 
lot of it was moving code around.

(That said, you seem to have changed names a lot too, so it's not pure 
code movement).

> 49 files changed, 5400 insertions(+), 5092 deletions(-)

With rename detection enabled, I get

 36 files changed, 3444 insertions(+), 3130 deletions(-)

due to finding some (partially dubious) renames:

 rename fs/9p/mux.h => include/net/9p/conn.h (53%)
 rename {fs => include/net}/9p/transport.h (59%)
 rename {fs => net}/9p/conv.c (55%)
 rename {fs => net}/9p/fcprint.c (64%)
 rename {fs => net}/9p/mux.c (55%)

even though is misses a lot of others (due to all the "v9fs" -> "p9" 
changes in the source code too - was that really worth it?).

			Linus

  reply	other threads:[~2007-07-15 23:49 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-14 20:20 Eric Van Hensbergen
2007-07-15 23:49 ` Linus Torvalds [this message]
2007-07-16  0:30   ` [V9fs-developer] " Latchesar Ionkov
2007-07-16  0:28     ` david
2007-07-16 16:29     ` Linus Torvalds
2007-07-16 16:45       ` Latchesar Ionkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LFD.0.999.0707151645561.20061@woody.linux-foundation.org \
    --to=torvalds@linux-foundation.org \
    --cc=ericvh@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=v9fs-developer@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®