From: Linus Torvalds <torvalds@linux-foundation.org>
To: Ingo Molnar <mingo@elte.hu>
Cc: Olaf Kirch <olaf.kirch@oracle.com>,
Jarek Poplawski <jarkao2@o2.pl>,
linux-kernel@vger.kernel.org, davem@davemloft.net
Subject: Re: [patch] revert: [NET]: Fix races in net_rx_action vs netpoll
Date: Tue, 17 Jul 2007 10:49:36 -0700 (PDT) [thread overview]
Message-ID: <alpine.LFD.0.999.0707171047200.19166@woody.linux-foundation.org> (raw)
In-Reply-To: <20070717085748.GA32114@elte.hu>
On Tue, 17 Jul 2007, Ingo Molnar wrote:
>
> i've got a new observation: changing CONFIG_HZ from 250 to 1000 makes
> the problem go away. So it's somehow also related to jiffies.
No, I suspect it's just related to timing: you need to hit that window
when the LIST_FROZEN bit is set, and since it was so reliable for you
before (and others didn't see it), your timing probably happened to hit it
exactly. And changing HZ probably just changed some timeout or softirq
getting called, and you didn't hit the bug any more.
Linus
next prev parent reply other threads:[~2007-07-17 17:51 UTC|newest]
Thread overview: 67+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-16 9:12 Ingo Molnar
2007-07-16 10:35 ` Olaf Kirch
2007-07-16 11:26 ` David Miller
2007-07-16 12:18 ` Olaf Kirch
2007-07-16 13:29 ` Ingo Molnar
2007-07-16 21:09 ` Ingo Molnar
2007-07-16 22:06 ` David Miller
2007-07-16 21:40 ` Linus Torvalds
2007-07-16 21:51 ` Ingo Molnar
2007-07-16 22:09 ` David Miller
2007-07-16 22:37 ` Ingo Molnar
2007-07-16 22:57 ` David Miller
2007-07-17 18:09 ` Ingo Molnar
2007-07-16 22:08 ` David Miller
2007-07-16 22:29 ` Linus Torvalds
2007-07-16 22:52 ` David Miller
2007-07-16 23:17 ` Matt Mackall
2007-07-16 23:34 ` Linus Torvalds
2007-07-17 7:37 ` Olaf Kirch
2007-07-17 8:16 ` Olaf Kirch
2007-07-17 5:46 ` Jarek Poplawski
2007-07-17 6:14 ` Jarek Poplawski
2007-07-17 7:55 ` Olaf Kirch
2007-07-17 8:28 ` Olaf Kirch
2007-07-17 8:57 ` Ingo Molnar
2007-07-17 9:29 ` Jarek Poplawski
2007-07-17 14:07 ` Olaf Kirch
2007-07-17 16:57 ` Ingo Molnar
2007-07-17 18:06 ` Olaf Kirch
2007-07-17 18:18 ` Ingo Molnar
2007-07-17 18:34 ` Olaf Kirch
2007-07-17 18:56 ` Ingo Molnar
2007-07-18 12:04 ` Olaf Kirch
2007-07-18 12:41 ` Ingo Molnar
2007-07-18 12:48 ` Ingo Molnar
2007-07-18 14:41 ` Olaf Kirch
2007-07-18 16:43 ` Ingo Molnar
2007-07-19 9:09 ` Ingo Molnar
2007-07-19 9:44 ` Olaf Kirch
2007-07-19 10:01 ` Ingo Molnar
2007-07-19 10:37 ` Olaf Kirch
2007-07-19 10:47 ` Ingo Molnar
2007-07-19 10:58 ` Ingo Molnar
2007-07-19 12:52 ` Olaf Kirch
2007-07-19 12:54 ` Olaf Kirch
2007-07-19 15:42 ` Kok, Auke
2007-07-19 16:07 ` Ingo Molnar
2007-07-19 19:13 ` Olaf Kirch
2007-07-19 19:22 ` Ingo Molnar
2007-07-19 19:35 ` Olaf Kirch
2007-07-19 19:56 ` Ingo Molnar
2007-07-19 20:02 ` Olaf Kirch
2007-07-20 9:45 ` Ingo Molnar
2007-07-19 15:07 ` Ingo Molnar
2007-07-19 15:27 ` Olaf Kirch
2007-07-19 15:32 ` Ingo Molnar
2007-07-19 15:52 ` Ingo Molnar
2007-07-19 16:05 ` Ingo Molnar
2007-07-19 16:13 ` Ingo Molnar
2007-07-19 17:36 ` Olaf Kirch
2007-07-19 17:41 ` Ingo Molnar
2007-07-19 17:51 ` Olaf Kirch
2007-07-19 10:17 ` Ingo Molnar
2007-07-18 11:48 ` Jarek Poplawski
2007-07-19 5:58 ` Jarek Poplawski
2007-07-17 17:49 ` Linus Torvalds [this message]
2007-07-17 9:12 ` Jarek Poplawski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.0.999.0707171047200.19166@woody.linux-foundation.org \
--to=torvalds@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=jarkao2@o2.pl \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=olaf.kirch@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®