From: Linus Torvalds <torvalds@linux-foundation.org>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: caglar@pardus.org.tr, Avi Kivity <avi@qumranet.com>,
linux-kernel@vger.kernel.org, kvm-devel@lists.sourceforge.net,
Andi Kleen <andi@firstfloor.org>
Subject: Re: [GIT PULL][RESEND #2] KVM Updates for 2.6.23-rc1
Date: Tue, 17 Jul 2007 12:15:06 -0700 (PDT) [thread overview]
Message-ID: <alpine.LFD.0.999.0707171212070.27353@woody.linux-foundation.org> (raw)
In-Reply-To: <469D1317.1050202@zytor.com>
On Tue, 17 Jul 2007, H. Peter Anvin wrote:
>
> S.Çağlar Onur wrote:
> >
> > If i'm not wrong X86_CMPXCHG64 depends on CONFIG_X86_PAE which depends on
> > HIGHMEM64 and again if i'm not wrong this means distributions who wants to
> > provide KVM must enable CONFIG_X86_PAE and CONFIG_HIGHMEM64G from now on?
> >
>
> X86_PAE should depend on X86_CMPXCHG64, not the other way around.
Actually, I think the *real* solution would be:
- add a X86_HAS_CMPXCHG8B config option, and set it for the appropriate
CPU selection (P6 and up, or whatever the rule is)
- make KVM depend on it
- make KVM and HIGHMEM64 _select_ another config option, namely the
NEEDS_CMPXCHG8B
and then we make the cpufeatures code check the CMPXCHG bit only if the
NEEDS_CMPXCHG8B thing is set. That gives us the best of all worlds.
Because there is no point in checking whether the CPU supports it if the
kernel doesn't _need_ it. Especially since we know that some CPU's lie
about it due to old NT bugs.
Linus
next prev parent reply other threads:[~2007-07-17 19:17 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-17 16:51 Avi Kivity
2007-07-17 18:39 ` S.Çağlar Onur
2007-07-17 19:05 ` H. Peter Anvin
2007-07-17 19:15 ` Linus Torvalds [this message]
2007-07-17 19:26 ` H. Peter Anvin
2007-07-17 23:25 ` S.Çağlar Onur
2007-07-17 23:38 ` [kvm-devel] " Anthony Liguori
2007-07-17 23:40 ` S.Çağlar Onur
2007-07-18 9:31 ` S.Çağlar Onur
2007-07-18 9:35 ` Avi Kivity
2007-07-18 10:09 ` S.Çağlar Onur
2007-07-18 10:17 ` S.Çağlar Onur
2007-07-18 10:31 ` Avi Kivity
2007-07-18 10:50 ` S.Çağlar Onur
2007-07-20 5:31 ` Avi Kivity
2007-07-20 11:37 ` S.Çağlar Onur
2007-07-18 17:46 ` S.Çağlar Onur
2007-07-18 18:04 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.0.999.0707171212070.27353@woody.linux-foundation.org \
--to=torvalds@linux-foundation.org \
--cc=andi@firstfloor.org \
--cc=avi@qumranet.com \
--cc=caglar@pardus.org.tr \
--cc=hpa@zytor.com \
--cc=kvm-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®