From: Linus Torvalds <torvalds@linux-foundation.org>
To: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Cc: Giacomo Catenazzi <cate@cateee.net>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Jens Axboe <jens.axboe@oracle.com>,
akpm@linux-foundation.org
Subject: Re: regression: disk error loop (panic?) ide_do_rw_disk-bad:
Date: Tue, 17 Jul 2007 14:24:21 -0700 (PDT) [thread overview]
Message-ID: <alpine.LFD.0.999.0707171417560.27353@woody.linux-foundation.org> (raw)
In-Reply-To: <200707172320.12141.bzolnier@gmail.com>
On Tue, 17 Jul 2007, Bartlomiej Zolnierkiewicz wrote:
>
> ide-disk driver and type 2 (REQ_TYPE_BLOCK_PC) requests don't mix well
>
> Probably some dumb application is sending packet commands without
> checking the device type...
Ok, we should definitely try to just translate the things, and instead of
having user apps that have to know about the (generally not very
interesting) differences between IDE and SCSI command set, and when the
IDE driver gets a SCSI request (whether from the new generic SG layer or
obviously the older SCSI-ioctl layer) it should "just work".
So I object to that "dumb application" statement. It's the kernel that has
traditionally been dumb in not smoothing over the differences between
devices well enough.
We shouldn't _need_ to have applications care. They should be able to just
use regular SCSI commands, and if the device cannot handle a 10-byte read
command, the kernel should have translated that into a 6-byte one (for
example) rather than the application having to know about idiotic small
differences like that.
That said, I dunno how to fix this particular one, and the IDE driver is
singularly unhelpful in actually talking about *what* the command tried to
be.
Linus
next prev parent reply other threads:[~2007-07-17 21:25 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-17 19:49 Giacomo Catenazzi
2007-07-17 20:47 ` Michal Piotrowski
2007-07-17 21:20 ` Bartlomiej Zolnierkiewicz
2007-07-17 21:24 ` Linus Torvalds [this message]
2007-07-17 22:45 ` Bartlomiej Zolnierkiewicz
2007-07-17 22:38 ` Linus Torvalds
2007-07-17 23:14 ` Bartlomiej Zolnierkiewicz
2007-07-17 23:18 ` Jeff Garzik
2007-07-18 8:09 ` Jens Axboe
2007-07-17 22:57 ` Linus Torvalds
2007-07-18 6:31 ` Giacomo Catenazzi
2007-07-18 19:57 ` Linus Torvalds
2007-07-18 20:08 ` Jens Axboe
2007-07-18 20:11 ` Jens Axboe
2007-07-18 20:14 ` Linus Torvalds
2007-07-18 20:27 ` Jens Axboe
2007-07-18 22:53 ` Bartlomiej Zolnierkiewicz
2007-07-18 23:20 ` Linus Torvalds
2007-07-19 6:13 ` Jens Axboe
2007-07-19 6:40 ` Giacomo Catenazzi
2007-07-19 6:47 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.0.999.0707171417560.27353@woody.linux-foundation.org \
--to=torvalds@linux-foundation.org \
--cc=akpm@linux-foundation.org \
--cc=bzolnier@gmail.com \
--cc=cate@cateee.net \
--cc=jens.axboe@oracle.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®