mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Linus Torvalds <torvalds@linux-foundation.org>
To: Roland Dreier <rdreier@cisco.com>
Cc: Pekka Enberg <penberg@cs.helsinki.fi>, Andi Kleen <ak@suse.de>,
	Christoph Lameter <clameter@sgi.com>,
	linux-kernel@vger.kernel.org,
	"Michael S. Tsirkin" <mst@dev.mellanox.co.il>
Subject: Re: kmalloc zero size changes break i386
Date: Thu, 19 Jul 2007 12:19:29 -0700 (PDT)	[thread overview]
Message-ID: <alpine.LFD.0.999.0707191218470.27353@woody.linux-foundation.org> (raw)
In-Reply-To: <alpine.LFD.0.999.0707191107570.27353@woody.linux-foundation.org>



On Thu, 19 Jul 2007, Linus Torvalds wrote:
> 
> Does something like this fix it?
> 
> Christoph, please go over this and see if there are other cases like that.

Actually, here's a better version, I think.

Andi, does this patch fix your problem?

		Linus
---
 mm/slab.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/mm/slab.c b/mm/slab.c
index 88bc633..c3feeaa 100644
--- a/mm/slab.c
+++ b/mm/slab.c
@@ -3690,8 +3690,8 @@ static __always_inline void *__do_kmalloc(size_t size, gfp_t flags,
 	 * functions.
 	 */
 	cachep = __find_general_cachep(size, flags);
-	if (unlikely(cachep == NULL))
-		return NULL;
+	if (unlikely(ZERO_OR_NULL_PTR(cachep)))
+		return cachep;
 	return __cache_alloc(cachep, flags, caller);
 }
 

  parent reply	other threads:[~2007-07-19 19:21 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-19 10:01 Andi Kleen
2007-07-19 14:08 ` Pekka Enberg
2007-07-19 15:17   ` Roland Dreier
2007-07-19 18:11     ` Linus Torvalds
2007-07-19 19:03       ` Pekka Enberg
2007-07-19 19:19       ` Linus Torvalds [this message]
2007-07-19 21:03         ` Andi Kleen
2007-07-20  7:12     ` Pekka J Enberg
2007-07-20  7:18       ` Pekka J Enberg
2007-07-20 19:13         ` [PATCH] Fix ZERO_OR_NULL_PTR(ZERO_SIZE_PTR) Roland Dreier
2007-07-19 17:01   ` kmalloc zero size changes break i386 Andi Kleen
2007-07-19 15:57 ` Linus Torvalds

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LFD.0.999.0707191218470.27353@woody.linux-foundation.org \
    --to=torvalds@linux-foundation.org \
    --cc=ak@suse.de \
    --cc=clameter@sgi.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mst@dev.mellanox.co.il \
    --cc=penberg@cs.helsinki.fi \
    --cc=rdreier@cisco.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®