From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934094AbXGYRUj (ORCPT ); Wed, 25 Jul 2007 13:20:39 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1760073AbXGYRUc (ORCPT ); Wed, 25 Jul 2007 13:20:32 -0400 Received: from smtp2.linux-foundation.org ([207.189.120.14]:46719 "EHLO smtp2.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753135AbXGYRUb (ORCPT ); Wed, 25 Jul 2007 13:20:31 -0400 Date: Wed, 25 Jul 2007 10:19:55 -0700 (PDT) From: Linus Torvalds To: Jeremy Fitzhardinge cc: David Miller , hpa@zytor.com, kaos@ocs.com.au, xyzzy@speakeasy.org, viro@ftp.linux.org.uk, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org Subject: Re: [PATCH][RFC] getting rid of stupid loop in BUG() In-Reply-To: <46A781A4.40103@goop.org> Message-ID: References: <21803.1185331847@ocs10w.ocs.com.au> <46A6DB04.3000003@zytor.com> <46A6ECB7.7090208@goop.org> <20070724.232914.56812376.davem@davemloft.net> <46A781A4.40103@goop.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 25 Jul 2007, Jeremy Fitzhardinge wrote: > > No, not any more. The file and line info is out of line, in a separate > section, indexed by the ud2a's eip. That's irrelevant - the point is, we need to do the ud2 by hand, since we need to control the code generation in order to associate the ud2 with the proper file/linenr. > The main problem with __builtin_trap is that there's no certain way to > get the actual ud2a eip (ie, paste an asm label onto it). Right. Which is why we need to do it as an inline asm. Linus