From: Linus Torvalds <torvalds@linux-foundation.org>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: Greg KH <gregkh@suse.de>, Oliver Neukum <oliver@neukum.org>,
USB development list <linux-usb-devel@lists.sourceforge.net>,
Andrew Morton <akpm@linux-foundation.org>,
Kernel development list <linux-kernel@vger.kernel.org>
Subject: Re: [linux-usb-devel] usb-storage autosuspend bug?
Date: Sun, 29 Jul 2007 20:00:01 -0700 (PDT) [thread overview]
Message-ID: <alpine.LFD.0.999.0707291956580.4161@woody.linux-foundation.org> (raw)
In-Reply-To: <Pine.LNX.4.44L0.0707271010320.3428-100000@iolanthe.rowland.org>
On Fri, 27 Jul 2007, Alan Stern wrote:
>
> I don't think it's a refcounting problem. My guess is that the
> underlying cause is the bug in your urb->status removal patch for
> usb_start_wait_urb() -- the one I fixed here:
>
> http://marc.info/?l=linux-usb-devel&m=118531582013355&w=2
>
> Of course, my guess could be wrong. I haven't tried to recreate
> Linus's bug with that patch reverted. But with the patch present I was
> not able to duplicate the bug.
I finally got around to testing this, and while I still have problems with
that reader, I can't reproduce the oops with that patch in place either.
Of course, I only ever saw the oops once, so I really don't know how
reproducible it was. Maybe you have to remove the USB reader at _just_ the
right moment. But I did get
...
usb 2-6: reset high speed USB device using ehci_hcd and address 4
usb 2-6: USB disconnect, address 4
sd 6:0:0:1: [sdc] Result: hostbyte=0x07 driverbyte=0x00
end_request: I/O error, dev sdc, sector 1999855
...
scsi 6:0:0:1: rejecting I/O to dead device
so the testing was done with the kind of behaviour that resulted in an
oops and a dead khubd last time around.
So I guess I'll ack the patch for whatever that is worth.
Over to you, Greg..
Linus
next prev parent reply other threads:[~2007-07-30 3:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-20 3:44 [GIT PATCH] more USB patches for 2.6.22 Greg KH
2007-07-25 23:34 ` Linus Torvalds
2007-07-26 15:35 ` [linux-usb-devel] " Alan Stern
2007-07-26 15:57 ` usb-storage autosuspend bug? Greg KH
2007-07-27 8:11 ` [linux-usb-devel] " Oliver Neukum
2007-07-27 14:14 ` Alan Stern
2007-07-30 3:00 ` Linus Torvalds [this message]
2007-07-30 22:11 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.0.999.0707291956580.4161@woody.linux-foundation.org \
--to=torvalds@linux-foundation.org \
--cc=akpm@linux-foundation.org \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb-devel@lists.sourceforge.net \
--cc=oliver@neukum.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®