From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932982AbXG3Imc (ORCPT ); Mon, 30 Jul 2007 04:42:32 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1760740AbXG3ImV (ORCPT ); Mon, 30 Jul 2007 04:42:21 -0400 Received: from pentafluge.infradead.org ([213.146.154.40]:40909 "EHLO pentafluge.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760593AbXG3ImU (ORCPT ); Mon, 30 Jul 2007 04:42:20 -0400 Date: Mon, 30 Jul 2007 14:24:30 +0530 (IST) From: Satyam Sharma X-X-Sender: satyam@enigma.security.iitk.ac.in To: Petko Manolov cc: Oliver Neukum , linux-usb-devel@lists.sourceforge.net, Jesper Juhl , Greg Kroah-Hartman , netdev@vger.kernel.org, Linux Kernel Mailing List , Petko Manolov Subject: Re: [linux-usb-devel] [PATCH] USB Pegasus driver - avoid a potential NULL pointer dereference. In-Reply-To: Message-ID: References: <200707290019.02591.jesper.juhl@gmail.com> <9a8748490707281655u66e50bbfqba58687b579a85fe@mail.gmail.com> <200707291049.26619.oliver@neukum.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 30 Jul 2007, Petko Manolov wrote: > On Sun, 29 Jul 2007, Oliver Neukum wrote: > > > [...] > > pegasus == NULL there would be a kernel bug. Silently ignoring > > it, like the code now wants to do is bad. As the oops has never been > > reported, I figure turning it into an explicit debugging test is overkill, > > so removal seems to be the best option. > > In the past urb->context was not guaranteed to be non-null for any > asynchronous calls. If this is not the case anymore then it should be removed > from at least two more locations in the driver. > > Attached you'll find the resulting patch. Given Oliver's earlier comment, it looks okay to me. Thanks.