From: Satyam Sharma <satyam@infradead.org>
To: Neil Horman <nhorman@tuxdriver.com>
Cc: akpm@linux-foundation.org, jeremy@goop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] argv_split: allow argv_split to handle NULL pointer in argcp parameter gracefully
Date: Tue, 31 Jul 2007 23:06:52 +0530 (IST) [thread overview]
Message-ID: <alpine.LFD.0.999.0707312303490.28746@enigma.security.iitk.ac.in> (raw)
In-Reply-To: <20070731164608.GB28333@hmsreliant.homelinux.net>
On Tue, 31 Jul 2007, Neil Horman wrote:
> As Jeremy and I had discussed in a previous thread, it would be nice if the
> argv_split library function could gracefully handle a NULL pointer in the argcp
> parameter, so as to allow functions using it that did not care about the value
> of argc to not have to declare a useless variable. This patch accomplishes
> that. Tested by me, with successful results.
The patch itself looks simple and straightforward enough, but having done
this, now you'd also want to cleanup the use of the dummy variable in the
callsites you mentioned above, correct? (Unless that's what Jeremy meant
in his reply already)
next prev parent reply other threads:[~2007-07-31 17:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-31 16:46 Neil Horman
2007-07-31 16:52 ` Jeremy Fitzhardinge
2007-07-31 16:56 ` Jeremy Fitzhardinge
2007-07-31 17:12 ` Neil Horman
2007-07-31 17:36 ` Satyam Sharma [this message]
2007-07-31 18:14 ` Neil Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.0.999.0707312303490.28746@enigma.security.iitk.ac.in \
--to=satyam@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=jeremy@goop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®