From: Satyam Sharma <satyam@infradead.org>
To: Jan Engelhardt <jengelh@computergmbh.de>
Cc: Guennadi Liakhovetski <g.liakhovetski@gmx.de>,
linux-kernel@vger.kernel.org
Subject: Re: gcc fixed size char array initialization bug - known?
Date: Fri, 3 Aug 2007 08:47:56 +0530 (IST) [thread overview]
Message-ID: <alpine.LFD.0.999.0708030841390.23798@enigma.security.iitk.ac.in> (raw)
In-Reply-To: <Pine.LNX.4.64.0708022157310.9319@fbirervta.pbzchgretzou.qr>
On Thu, 2 Aug 2007, Jan Engelhardt wrote:
> On Aug 2 2007 21:55, Guennadi Liakhovetski wrote:
> > [...]
> >
> > struct {
> > char c[4];
> > int i;
> > } t;
> > t.i = 0x12345678;
> > strcpy(t.c, c);
> >
> >and t.i is silently corrupted. Just wanted to ask if this is known,
> >really...
>
> What does this have to do with the kernel? The string "0123" is
> generally _five_ characters long, so c[4] is not enough.
> Or use strncpy.
<nitpicking>
While we're talking of null-termination of strings, then I bet you
generally want to be using strlcpy(), really. Often strncpy() isn't
what you want. Of course, if that buffer isn't a string at all, then
you should be using memfoo() functions and not strbar() ones in the
first place ...
next prev parent reply other threads:[~2007-08-03 3:05 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-02 19:55 Guennadi Liakhovetski
2007-08-02 19:59 ` Jan Engelhardt
2007-08-02 20:03 ` Jesper Juhl
2007-08-02 20:10 ` Al Viro
2007-08-02 20:12 ` Jesper Juhl
2007-08-02 20:15 ` Guennadi Liakhovetski
2007-08-03 3:17 ` Satyam Sharma [this message]
2007-08-03 3:40 ` WANG Cong
2007-08-03 7:32 ` Bernd Petrovitsch
2007-08-02 20:08 ` Al Viro
2007-08-02 20:21 ` Guennadi Liakhovetski
2007-08-02 20:26 ` Guennadi Liakhovetski
2007-08-02 21:09 ` Al Viro
2007-08-02 21:26 ` Guennadi Liakhovetski
2007-08-02 20:18 ` Jan Engelhardt
2007-08-02 21:06 ` Andi Kleen
2007-08-02 20:36 ` Guennadi Liakhovetski
2007-08-02 22:15 ` Stefan Richter
2007-08-02 22:36 ` Guennadi Liakhovetski
2007-08-02 22:42 ` (off-topic) " Stefan Richter
2007-08-02 22:54 ` Randy Dunlap
2007-08-02 23:03 ` Al Viro
2007-08-02 23:26 ` Guennadi Liakhovetski
2007-08-02 23:34 ` Rene Herman
2007-08-03 5:00 ` Carlo Florendo
2007-08-02 23:02 ` Al Viro
2007-08-03 4:57 ` Carlo Florendo
2007-08-02 22:31 ` Stefan Richter
2007-08-02 22:51 ` Guennadi Liakhovetski
2007-08-02 23:09 ` Al Viro
2007-08-02 23:27 ` Stefan Richter
2007-08-02 23:30 ` Guennadi Liakhovetski
2007-08-03 7:56 ` Jan Engelhardt
2007-08-03 14:04 ` Alexander van Heukelum
2007-08-02 23:42 ` Jakub Jelinek
2007-08-03 15:16 ` Stefan Richter
[not found] <fa.LxMYkBaN628VuktB9CFi9SC3LTA@ifi.uio.no>
[not found] ` <fa.6wYNfcIjXc+jXzdUGE5gFFOal1g@ifi.uio.no>
[not found] ` <fa.cjPWb5ZShF43DhggNXkMKMadPYY@ifi.uio.no>
2007-08-02 21:42 ` Robert Hancock
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.0.999.0708030841390.23798@enigma.security.iitk.ac.in \
--to=satyam@infradead.org \
--cc=g.liakhovetski@gmx.de \
--cc=jengelh@computergmbh.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®