From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1764275AbXHCWC1 (ORCPT ); Fri, 3 Aug 2007 18:02:27 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1761886AbXHCWCU (ORCPT ); Fri, 3 Aug 2007 18:02:20 -0400 Received: from smtp2.linux-foundation.org ([207.189.120.14]:43011 "EHLO smtp2.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753927AbXHCWCU (ORCPT ); Fri, 3 Aug 2007 18:02:20 -0400 Date: Fri, 3 Aug 2007 15:01:44 -0700 (PDT) From: Linus Torvalds To: "Rafael J. Wysocki" cc: Andrew Morton , Len Brown , LKML , Pavel Machek , pm list , Adrian Bunk Subject: Re: [PATCH] PM: Fix dependencies of CONFIG_SUSPEND and CONFIG_HIBERNATION In-Reply-To: <200708032359.37677.rjw@sisk.pl> Message-ID: References: <200708032359.37677.rjw@sisk.pl> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 3 Aug 2007, Rafael J. Wysocki wrote: > depends on PM > - depends on !SMP || SUSPEND_SMP_POSSIBLE > + depends on SUSPEND_SMP_POSSIBLE || ((BLACKFIN || MIPS || SUPERH || FRV \ > + || (PPC32 && PPC_MPC52xx)) && !SMP) Please, do that as SUSPEND_UP_POSSIBLE, and make it look like config SUSPEND_UP_POSSIBLE depends on BLACKFIN || MIPS || SUPERH || FRV || ((PPC32 && PPC_MPC52xx) depends on !SMP default y and now you can write the above thing as depends on SUSPEND_SMP_POSSIBLE || SUSPEND_UP_POSSIBLE and it's all much nicer. I would say that doing a similar setup for HIBERNATE would be nice too, but the SUSPEND case is more noticeable because the SMP case is so nice already. Linus