From: Linus Torvalds <torvalds@linux-foundation.org>
To: Petr Vandrovec <petr@vandrovec.name>
Cc: ak@suse.de, discuss@x86-64.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Fix triplefault on x86-64 bootup
Date: Sun, 12 Aug 2007 01:59:16 -0700 (PDT) [thread overview]
Message-ID: <alpine.LFD.0.999.0708120151150.30176@woody.linux-foundation.org> (raw)
In-Reply-To: <alpine.LFD.0.999.0708120140160.30176@woody.linux-foundation.org>
On Sun, 12 Aug 2007, Linus Torvalds wrote:
>
> Hmm. Patch looks ok, I just wonder what started triggering this for you?
Oh. It's the "Make patching more robust" commit.
"Robust" my ass.
We used to just copy the replacement in one go (works fine, since it just
overwrote the two first bytes), and then "nop_out()" the rest (works fine,
since it didn't matter for memcpy).
That whole commit looks a bit dubious. It also adds a 254-byte stack
usage (anything actually even close to that big?). Gaah.
Linus
next prev parent reply other threads:[~2007-08-12 8:59 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-12 8:12 Petr Vandrovec
2007-08-12 8:40 ` Linus Torvalds
2007-08-12 8:59 ` Linus Torvalds [this message]
2007-08-12 10:01 ` Andi Kleen
2007-08-12 9:59 ` Andi Kleen
2007-08-12 17:56 ` Linus Torvalds
2007-08-12 9:57 ` [discuss] " Andi Kleen
2007-08-12 10:09 ` Please remove ab144f5ec64c42218a555ec1dbde6b60cf2982d6 was " Andi Kleen
2007-08-12 10:42 ` Petr Vandrovec
2007-08-12 13:55 ` Andi Kleen
2007-08-12 13:46 ` Paolo Ornati
2007-08-12 17:57 ` Linus Torvalds
2007-08-12 10:46 ` Alexey Dobriyan
2007-08-12 13:53 ` Andi Kleen
2007-08-12 13:12 ` Alexey Dobriyan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.0.999.0708120151150.30176@woody.linux-foundation.org \
--to=torvalds@linux-foundation.org \
--cc=ak@suse.de \
--cc=discuss@x86-64.org \
--cc=linux-kernel@vger.kernel.org \
--cc=petr@vandrovec.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®