From: Linus Torvalds <torvalds@linux-foundation.org>
To: Andi Kleen <ak@suse.de>
Cc: dean@arctic.org, patches@x86-64.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] [1/12] x86: Work around mmio config space quirk on AMD Fam10h
Date: Sun, 12 Aug 2007 12:15:26 -0700 (PDT) [thread overview]
Message-ID: <alpine.LFD.0.999.0708121205210.30176@woody.linux-foundation.org> (raw)
In-Reply-To: <200708121203.23741.ak@suse.de>
On Sun, 12 Aug 2007, Andi Kleen wrote:
> >
> > Damn you, Andi.
>
> Thanks for the kind words.
Should I be impressed by the fact that 16% of your patches caused bootup
problems, when we're really close to a -rc3, and *long* past the point
where we want to address regressions rather than cause them?
I simply want you to be more careful. *Much* more careful. As it is, I
end up always being afraid of merging your patch-series (and yes, I should
have found this even earlier when reading through the diff rather than
after I had already applied it, but I didn't, and we had a broken kernel
for a few hours as a result. I didn't see any bug-reports about this one,
so hopefully nobody noticed, but it still grates me).
Bugs happen, but (a) they should happen during the merge window, not when
we're in stabilization phase and (b) the percentages here were just not
very good.
Linus
next prev parent reply other threads:[~2007-08-12 19:16 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-09 12:41 [PATCH] [0/12] x86 Late merge bug fixes for 2.6.23 Andi Kleen
2007-08-09 12:41 ` [PATCH] [1/12] x86: Work around mmio config space quirk on AMD Fam10h Andi Kleen
2007-08-10 10:19 ` [patches] " Joachim Deguara
2007-08-12 9:25 ` Linus Torvalds
2007-08-12 10:03 ` Andi Kleen
2007-08-12 19:15 ` Linus Torvalds [this message]
2007-08-13 3:06 ` Dave Jones
2007-08-13 3:26 ` Linus Torvalds
2007-08-13 3:38 ` dean gaudet
2007-08-09 12:41 ` [PATCH] [2/12] x86_64: Calgary - Fix mis-handled PCI topology Andi Kleen
2007-08-09 12:41 ` [PATCH] [3/12] x86_64: Don't mark __exitcall as __cold Andi Kleen
2007-08-09 12:41 ` [PATCH] [4/12] x86_64: Disable CLFLUSH support again Andi Kleen
2007-08-09 12:54 ` [patches] " Jan Beulich
2007-08-09 13:11 ` Muli Ben-Yehuda
2007-08-09 13:12 ` Andi Kleen
2007-08-09 13:29 ` [patches] " Jan Beulich
2007-08-09 16:24 ` Muli Ben-Yehuda
2007-08-09 12:41 ` [PATCH] [5/12] x86_64: Make patching more robust, fix paravirt issue Andi Kleen
2007-08-18 0:05 ` Jeremy Fitzhardinge
2007-08-18 0:11 ` Chris Wright
2007-08-18 9:49 ` Andi Kleen
2007-08-18 20:32 ` Chris Wright
2007-08-18 20:55 ` Linus Torvalds
2007-08-18 21:31 ` Chris Wright
2007-08-18 22:28 ` [PATCH] x86: skip paravirt patching when appropriate Chris Wright
2007-08-19 3:08 ` Zachary Amsden
2007-08-19 5:55 ` Zachary Amsden
2007-08-18 21:58 ` [PATCH] [5/12] x86_64: Make patching more robust, fix paravirt issue Jeremy Fitzhardinge
2007-08-20 1:50 ` Rusty Russell
2007-08-20 2:07 ` Chris Wright
2007-08-20 6:15 ` Jeremy Fitzhardinge
2007-08-21 7:30 ` Glauber de Oliveira Costa
2007-08-21 11:23 ` Andi Kleen
2007-08-21 12:26 ` Glauber de Oliveira Costa
2007-08-09 12:41 ` [PATCH] [6/12] x86_64: Early segment setup for VT Andi Kleen
2007-10-11 21:30 ` H. Peter Anvin
2007-08-09 12:41 ` [PATCH] [7/12] x86_64: really stop MCEs during code patching Andi Kleen
2007-08-09 12:41 ` [PATCH] [8/12] x86_64: Use global flag to disable broken local apic timer on AMD CPUs Andi Kleen
2007-08-09 16:46 ` Cal Peake
2007-08-09 16:50 ` Andi Kleen
2007-08-09 12:41 ` [PATCH] [9/12] x86_64: Avoid NMI Watchdog and/or long wait in setup_APIC_timer Andi Kleen
2007-08-09 12:41 ` [PATCH] [10/12] x86_64: Add warning in Documentation that zero-page is not a stable ABI Andi Kleen
2007-08-09 12:41 ` [PATCH] [11/12] x86_64: vdso.lds in arch/x86_64/vdso/.gitignore Andi Kleen
2007-08-09 12:41 ` [PATCH] [12/12] x86_64: Fix start_kernel warning Andi Kleen
2007-08-09 13:06 ` [PATCH] [0/12] x86 Late merge bug fixes for 2.6.23 Muli Ben-Yehuda
2007-08-09 13:12 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.0.999.0708121205210.30176@woody.linux-foundation.org \
--to=torvalds@linux-foundation.org \
--cc=ak@suse.de \
--cc=dean@arctic.org \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@x86-64.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®