From: Satyam Sharma <satyam@infradead.org>
To: Paul Mundt <lethal@linux-sh.org>
Cc: "Robert P. J. Day" <rpjday@mindspring.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: what is the value of the macro "__setup_param"?
Date: Fri, 24 Aug 2007 16:59:15 +0530 (IST) [thread overview]
Message-ID: <alpine.LFD.0.999.0708241650540.20322@enigma.security.iitk.ac.in> (raw)
In-Reply-To: <20070824100217.GA32109@linux-sh.org>
On Fri, 24 Aug 2007, Paul Mundt wrote:
>
> > > > include/linux/init.h:#define __setup_param(str, unique_id, fn, early) \
> > > > include/linux/init.h:#define __setup_param(str, unique_id, fn) /* nothing */
>
> Notice the problem now? :-)
We should probably keep it that way. I don't see why anybody should be
using __setup_param directly anyway, so this becomes a nice build-time
error to flag such errant usage :-)
Seriously speaking, though, we should probably just get rid of that
wrong line. It's just an init.h-internal macro to be used by early_param
and __setup, and because those are themselves empty when MODULE, there's
no issues in removing the (unused, broken) __setup_param either.
prev parent reply other threads:[~2007-08-24 11:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-24 9:19 Robert P. J. Day
2007-08-24 9:37 ` Adrian Bunk
2007-08-24 9:32 ` Robert P. J. Day
2007-08-24 9:50 ` Paul Mundt
2007-08-24 9:49 ` Robert P. J. Day
2007-08-24 10:02 ` Paul Mundt
2007-08-24 10:01 ` Robert P. J. Day
2007-08-24 11:29 ` Satyam Sharma [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.0.999.0708241650540.20322@enigma.security.iitk.ac.in \
--to=satyam@infradead.org \
--cc=lethal@linux-sh.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rpjday@mindspring.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®