mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Satyam Sharma <satyam@infradead.org>
To: Jeff Garzik <jeff@garzik.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Alasdair G Kergon <agk@redhat.com>,
	dm-devel@redhat.com, Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH -mm] drivers/md/: Shut up uninitialized variable warnings
Date: Mon, 3 Sep 2007 02:27:48 +0530 (IST)	[thread overview]
Message-ID: <alpine.LFD.0.999.0709030220210.29617@enigma.security.iitk.ac.in> (raw)
In-Reply-To: <46DB1E5C.2080107@garzik.org>

[-- Attachment #1: Type: TEXT/PLAIN, Size: 1920 bytes --]



On Sun, 2 Sep 2007, Jeff Garzik wrote:

> Satyam Sharma wrote:
> > drivers/md/dm-exception-store.c: In function ‘persistent_read_metadata’:
> > drivers/md/dm-exception-store.c:452: warning: ‘new_snapshot’ may be used
> > uninitialized in this function
> > 
> > drivers/md/dm-ioctl.c: In function ‘ctl_ioctl’:
> > drivers/md/dm-ioctl.c:1407: warning: ‘param’ may be used uninitialized in
> > this function
> > 
> > [ For these, I'd like to especially add -- shame on you, gcc! ]
> > 
> > drivers/md/dm-table.c: In function ‘dm_get_device’:
> > drivers/md/dm-table.c:472: warning: ‘dev’ may be used uninitialized in this
> > function
> > 
> > are all verified to be bogus warnings. Let's shut them up.
> > 
> > ---
> > 
> >  drivers/md/dm-exception-store.c |    3 ++-
> >  drivers/md/dm-ioctl.c |    2 +-
> >  drivers/md/dm-table.c |    2 +-
> >  3 file changed, 4 insertions(+), 3 deletion(-)
> 
> same comment as with the last uninit'd var patch:  these markers should be
> used sparingly.  Try it on multiple compiler versions, see if it's a new
> behavior.
> 
> Quite realistically, you might actually be finding gcc bugs,

Definitely -- a lot of these patches are purely a result of gcc's shoddy
inadequacies. I do intend filing reports with gcc, however ...

> implying the
> proper path is to file a gcc bug report (and they are _very_ diligent about
> handling these, its impressive) rather than to patch the Linux kernel.

My experience (regarding gcc's diligence in dealing with bug reports) has
been otherwise :-)

Anyway, I once had a _very_ similar discussion with Andrew (regarding some
other gcc bug) previously, and the (completely correct) point he made was
that: firstly, there's no guarantee they'll get this sorted out asap, and
even if they did, we'll still not be dropping support for older gcc
versions anyway ...

  reply	other threads:[~2007-09-02 20:44 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <alpine.LFD.0.999.0709022344550.27844@enigma.security.iitk.ac.i n>
2007-09-02 20:02 ` [-mm patchset] War on warnings Satyam Sharma
2007-09-02 20:04   ` Jesper Juhl
2007-09-02 20:39     ` Satyam Sharma
2007-09-02 20:30       ` Jesper Juhl
2007-09-02 20:07   ` [PATCH -mm] sisusbvga: Fix bug and build warnings Satyam Sharma
2007-09-02 20:11     ` Jesper Juhl
2007-09-02 20:32       ` Satyam Sharma
2007-09-02 20:23         ` Jesper Juhl
2007-09-02 21:18           ` Alistair John Strachan
2007-09-02 21:38             ` Satyam Sharma
2007-09-02 22:27               ` Satyam Sharma
2007-09-09 21:32     ` patch usb-sisusbvga-fix-bug-and-build-warnings.patch added to gregkh-2.6 tree gregkh
2007-09-02 20:09   ` [PATCH -mm] sunrpc svc: Shut up bogus uninitialized variable warning Satyam Sharma
2007-09-02 20:11   ` [PATCH -mm] net/wireless/sysfs.c: Shut up build warning Satyam Sharma
2007-09-02 20:24     ` Johannes Berg
2007-09-02 20:12   ` [PATCH -mm] drivers/usb/serial/bus.c: Fix incompatible pointer type warning Satyam Sharma
2007-09-02 20:13   ` [PATCH -mm] IPS SCSI driver: Check return of scsi_add_host() Satyam Sharma
2007-09-02 20:03     ` Jesper Juhl
2007-09-02 20:32     ` Jeff Garzik
2007-09-02 22:39       ` Satyam Sharma
2007-09-02 20:15   ` [PATCH -mm] sb16: Shut up uninitialized var build warning Satyam Sharma
2007-09-02 22:06     ` Rene Herman
2007-09-02 22:34       ` Satyam Sharma
2007-09-20 17:52       ` Denys Vlasenko
2007-09-22  4:20         ` Rene Herman
2007-09-02 20:16   ` [PATCH -mm] drivers/mmc/core/bus.c: Fix unused var warning Satyam Sharma
2007-09-03  9:04     ` Pierre Ossman
2007-09-02 20:18   ` [PATCH -mm] I2O: Fix "defined but not used" build warnings Satyam Sharma
2007-09-02 20:20   ` [PATCH -mm] mpt fusion: Shut up uninitialized variable warnings Satyam Sharma
2007-09-02 20:21   ` [PATCH -mm] es18xx: Shut up uninitialized var build warning Satyam Sharma
2007-09-02 22:14     ` Rene Herman
2007-09-02 20:22   ` [PATCH -mm] drivers/md/: Shut up uninitialized variable warnings Satyam Sharma
2007-09-02 20:34     ` Jeff Garzik
2007-09-02 20:57       ` Satyam Sharma [this message]
2007-09-02 20:23   ` [PATCH -mm] DC395x SCSI driver: Shut up uninitialized variable build warning Satyam Sharma
2007-09-02 20:23     ` Jeff Garzik
2007-09-02 20:49       ` Satyam Sharma
2007-09-02 20:43         ` Jeff Garzik
2007-09-02 20:24   ` [PATCH -mm] i386 cpuid_count: Fix argument signedness warnings Satyam Sharma

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LFD.0.999.0709030220210.29617@enigma.security.iitk.ac.in \
    --to=satyam@infradead.org \
    --cc=agk@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=dm-devel@redhat.com \
    --cc=jeff@garzik.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®