From: Satyam Sharma <satyam@infradead.org>
To: Willy Tarreau <w@1wt.eu>
Cc: Axel Reinhold <axel@freakout.de>,
Richard Kojedzinszky <krichy@tvnetwork.hu>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: 2.4.35.1 and panic at boot with arch=c3 and gcc-4.x
Date: Thu, 6 Sep 2007 04:10:11 +0530 (IST) [thread overview]
Message-ID: <alpine.LFD.0.999.0709060404070.26804@enigma.security.iitk.ac.in> (raw)
In-Reply-To: <20070905220027.GB11602@1wt.eu>
On Thu, 6 Sep 2007, Willy Tarreau wrote:
>
> I finally tracked the problem down to a dirty trick used to prevent
> do_test_wp_bit() from being inlined (Axel, you identified the right
> file). Unfortunately, this trick does not work anymore when gcc-4.x
> is used without -fno-unit-at-a-time, so let's use the correct method
> instead.
>
>
> -/* Put this after the callers, so that it cannot be inlined */
> -static int do_test_wp_bit(unsigned long vaddr)
Ick, that was horrible indeed!
> I really hope that this trick is not used anywhere else!
Me too ... funnily enough, 2.6.23-rc5 still has that wrong comment in it!
next prev parent reply other threads:[~2007-09-05 22:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-05 22:00 Willy Tarreau
2007-09-05 22:40 ` Satyam Sharma [this message]
2007-09-06 14:37 ` Richard Kojedzinszky
2007-09-06 14:50 ` Willy Tarreau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.0.999.0709060404070.26804@enigma.security.iitk.ac.in \
--to=satyam@infradead.org \
--cc=axel@freakout.de \
--cc=krichy@tvnetwork.hu \
--cc=linux-kernel@vger.kernel.org \
--cc=w@1wt.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®