From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761678AbXIUTFM (ORCPT ); Fri, 21 Sep 2007 15:05:12 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1758265AbXIUTFA (ORCPT ); Fri, 21 Sep 2007 15:05:00 -0400 Received: from smtp2.linux-foundation.org ([207.189.120.14]:44393 "EHLO smtp2.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751773AbXIUTFA (ORCPT ); Fri, 21 Sep 2007 15:05:00 -0400 Date: Fri, 21 Sep 2007 12:05:11 -0700 (PDT) From: Linus Torvalds To: Christoph Lameter cc: "Siddha, Suresh B" , akpm@linux-foundation.org, ak@suse.de, linux-kernel@vger.kernel.org, tony.luck@intel.com, asit.k.mallick@intel.com Subject: Re: x86_64: potential critical issue with quicklists and page table pages In-Reply-To: Message-ID: References: <20070921180742.GH20863@linux-os.sc.intel.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 21 Sep 2007, Linus Torvalds wrote: > > On Fri, 21 Sep 2007, Christoph Lameter wrote: > > > > The quicklists collect pages while we gather pages for TLB flushing. > > These pages must be kept until the actual TLB flush has occurred. The > > optimization of releasing off node pages early is therefore not valid. > > That should be the "mmu_gather" structure, not the quicklists. Oh, and I see what's wrong: you not only switched "free_page()" to "quicklist_free()", you *also* switched "tlb_remove_page()" to "quicklist_free()". Ok, that commit is totally and utterly broken. Will revert. Linus