From: Linus Torvalds <torvalds@linux-foundation.org>
To: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
Cc: Dave Jones <davej@redhat.com>,
Arjan van de Ven <arjan@infradead.org>,
Cyrill Gorcunov <gorcunov@gmail.com>,
LKML <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Ingo Molnar <mingo@elte.hu>
Subject: Re: memset as memzero
Date: Sun, 23 Sep 2007 10:05:05 -0700 (PDT) [thread overview]
Message-ID: <alpine.LFD.0.999.0709230956040.16478@woody.linux-foundation.org> (raw)
In-Reply-To: <20070923160750.GO4887@ghostprotocols.net>
On Sun, 23 Sep 2007, Arnaldo Carvalho de Melo wrote:
>
> bzero! That is it, its nothing new, just a sane name to something [..]
No, please no!
The BSD memory functions are nasty. If you do bzero, you logically should
do the others too, and they are way inferior to the standard ones. Let's
not go there.
Besides, if we want to avoid mistakes, I would suggest going to a much
higher level. Ie more along the lines of also fixing the size and
alignment, and using something like
#define memclear(p) memset(p, 0, sizeof(*(p)))
because if you actually do something like
git grep 'memset.*,[ ]*0[ ]*,'
(those [..] things contatain a space and a tab), you'll see that a *lot*
of them share that pattern.
Not that I think it's really worth it.
Linus
next prev parent reply other threads:[~2007-09-23 17:11 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-22 8:33 Cyrill Gorcunov
2007-09-22 8:48 ` Robert P. J. Day
2007-09-22 9:35 ` Cyrill Gorcunov
2007-09-22 9:55 ` Robert P. J. Day
2007-09-22 10:15 ` Cyrill Gorcunov
2007-09-22 19:46 ` Arjan van de Ven
2007-09-22 18:53 ` Linus Torvalds
2007-09-23 15:32 ` Dave Jones
2007-09-23 16:07 ` Arnaldo Carvalho de Melo
2007-09-23 17:05 ` Linus Torvalds [this message]
2007-09-23 18:46 ` Willy Tarreau
2007-09-23 16:33 ` Robert P. J. Day
2007-09-23 16:46 ` Arnaldo Carvalho de Melo
2007-09-22 19:25 ` Bernd Eckenfels
2007-09-22 20:37 ` Oleg Verych (nntp)
2007-09-22 19:32 ` Cyrill Gorcunov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.0.999.0709230956040.16478@woody.linux-foundation.org \
--to=torvalds@linux-foundation.org \
--cc=acme@ghostprotocols.net \
--cc=akpm@linux-foundation.org \
--cc=arjan@infradead.org \
--cc=davej@redhat.com \
--cc=gorcunov@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®