Re: [patch] scsi: fix crash in gdth_timeout()

[Linus Torvalds <torvalds@linux-foundation.org>]

On Mon, 15 Oct 2007, Ingo Molnar wrote:
> 
> A further problem is probably that the GDTH timer is not stopped by a
> failed GDTH probe?

Indeed. Maybe this is a better fix?

That driver is pretty messy, and this should have been found ealier. 
James? Boaz?

		Linus

---
 drivers/scsi/gdth.c |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)

diff --git a/drivers/scsi/gdth.c b/drivers/scsi/gdth.c
index e8010a7..3ac080e 100644
--- a/drivers/scsi/gdth.c
+++ b/drivers/scsi/gdth.c
@@ -5213,6 +5213,10 @@ static int __init gdth_init(void)
 #endif /* CONFIG_PCI */
 
 	TRACE2(("gdth_detect() %d controller detected\n", gdth_ctr_count));
+
+	if (list_empty(&gdth_instances))
+		return -ENODEV;
+
 #ifdef GDTH_STATISTICS
 	TRACE2(("gdth_detect(): Initializing timer !\n"));
 	init_timer(&gdth_timer);