From: Linus Torvalds <torvalds@linux-foundation.org>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: linux-kernel@vger.kernel.org, lguest <lguest@ozlabs.org>,
virtualization@lists.linux-foundation.org,
Jeremy Fitzhardinge <jeremy@goop.org>,
"H. Peter Anvin" <hpa@zytor.com>
Subject: Re: [git pull] lguest: paravirt boot code
Date: Tue, 23 Oct 2007 09:10:21 -0700 (PDT) [thread overview]
Message-ID: <alpine.LFD.0.999.0710230903330.30120@woody.linux-foundation.org> (raw)
In-Reply-To: <200710231603.21620.rusty@rustcorp.com.au>
On Tue, 23 Oct 2007, Rusty Russell wrote:
>
> Well, with that out the way, and some scatterlist fixups, please pull from
>
> git://git.kernel.org/pub/scm/linux/kernel/git/rusty/linux-2.6-lguest.git
Ok. However, please include a proper diffstat. And by proper, I mean:
git diff -M --stat --summary
because right now your diffstat doesn't contain the final "total number of
lines added/removed" (which is the easiest way for me to see that there
isn't anything strange in there), and your diffstat doesn't do renames, so
renames look like delete/create pairs. For example, you had:
> arch/x86/lguest/boot.c | 1070 ++++++++++++++++++++++
> drivers/lguest/lguest.c | 1108 ----------------------
but in reality it was not at all thousands of lines changed, but instead a
rename with much smaller changes:
drivers/lguest/lguest.c => arch/x86/lguest/boot.c | 102 +-
which is a lot more readable and tells me much more about what is going
on.
And at the end, I really do want to see the details like this:
70 files changed, 4822 insertions(+), 4401 deletions(-)
create mode 100644 arch/x86/lguest/Kconfig
create mode 100644 arch/x86/lguest/Makefile
rename drivers/lguest/lguest.c => arch/x86/lguest/boot.c (93%)
rename drivers/lguest/lguest_asm.S => arch/x86/lguest/i386_head.S (73%)
delete mode 100644 drivers/block/lguest_blk.c
create mode 100644 drivers/block/virtio_blk.c
delete mode 100644 drivers/char/hvc_lguest.c
create mode 100644 drivers/char/virtio_console.c
delete mode 100644 drivers/lguest/io.c
delete mode 100644 drivers/lguest/lguest_bus.c
create mode 100644 drivers/lguest/lguest_device.c
create mode 100644 drivers/lguest/x86/core.c
rename drivers/lguest/{switcher.S => x86/switcher_32.S} (99%)
delete mode 100644 drivers/net/lguest_net.c
create mode 100644 drivers/net/virtio_net.c
create mode 100644 drivers/virtio/Kconfig
create mode 100644 drivers/virtio/Makefile
create mode 100644 drivers/virtio/config.c
create mode 100644 drivers/virtio/virtio.c
create mode 100644 drivers/virtio/virtio_ring.c
create mode 100644 include/asm-x86/lguest.h
create mode 100644 include/asm-x86/lguest_hcall.h
delete mode 100644 include/linux/lguest_bus.h
create mode 100644 include/linux/virtio.h
create mode 100644 include/linux/virtio_blk.h
create mode 100644 include/linux/virtio_config.h
create mode 100644 include/linux/virtio_console.h
create mode 100644 include/linux/virtio_net.h
create mode 100644 include/linux/virtio_ring.h
which again gives a nice overview of what the heck is actually going on
here. All of which you get for free if you use the above git command line.
Anyway, pulled. But just for future reference,
Linus
next prev parent reply other threads:[~2007-10-23 16:11 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-22 2:37 Rusty Russell
2007-10-23 2:28 ` Linus Torvalds
2007-10-23 6:03 ` Rusty Russell
2007-10-23 6:55 ` Christian Borntraeger
2007-10-23 7:44 ` Rusty Russell
2007-10-23 16:10 ` Linus Torvalds [this message]
2007-10-23 20:37 ` Jeff Garzik
2007-10-25 5:19 ` Rusty Russell
2007-10-25 6:31 ` Stephen Rothwell
2007-10-25 22:41 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.0.999.0710230903330.30120@woody.linux-foundation.org \
--to=torvalds@linux-foundation.org \
--cc=hpa@zytor.com \
--cc=jeremy@goop.org \
--cc=lguest@ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®