From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754325AbXJYWFM (ORCPT ); Thu, 25 Oct 2007 18:05:12 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752972AbXJYWE4 (ORCPT ); Thu, 25 Oct 2007 18:04:56 -0400 Received: from smtp2.linux-foundation.org ([207.189.120.14]:57974 "EHLO smtp2.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756666AbXJYWEz (ORCPT ); Thu, 25 Oct 2007 18:04:55 -0400 Date: Thu, 25 Oct 2007 15:04:18 -0700 (PDT) From: Linus Torvalds To: Andrew Morton cc: Mark Lord , linux-kernel@vger.kernel.org Subject: Re: [PATCH] Fix /proc/acpi/alarm BCD alarm encodings In-Reply-To: <20071018151114.b1a0431e.akpm@linux-foundation.org> Message-ID: References: <4716D088.3040608@rtr.ca> <20071018151114.b1a0431e.akpm@linux-foundation.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 18 Oct 2007, Andrew Morton wrote: > On Wed, 17 Oct 2007 23:18:32 -0400 > Mark Lord wrote: > > > >and note the "& 0x3f" which is done in BCD mode. Strange. But we always > > >write zero (which may or may not be correct). So I'd have to add a mask to > > >the interface, and I decided it wasn't worth it until somebody talks about > > >how that thing actually works.. > > > > Linus, this is your patch from a few weeks ago. > > It (still) solves problems for me here. > > This should go into 2.6.24. > > > > Fix BIN_TO_BCD()/BCD_TO_BIN() handling when setting the real-time alarm clock. > > This patch is presently (stuck) in -mm. I'll move it to my > must-be-in-2.6.24-even-if-the-maintainer-fluffs-it queue. I noticed that apparently this never happened, and it didn't go into -rc1. I'll put it there myself, since I'm the author and Mark tested it, and the old code was definitely totally buggy. The earlier it gets in, the better, in case there are cleanups and/or other issues. Linus