From: Linus Torvalds <torvalds@linux-foundation.org>
To: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Cc: Russell King <rmk@arm.linux.org.uk>,
linux-ide@vger.kernel.org,
Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>,
Jeff Garzik <jgarzik@pobox.com>,
Alan Cox <alan@lxorguk.ukuu.org.uk>,
Linux Kernel List <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: Regression: commit "ide: constify struct ide_port_info" causes breakage
Date: Fri, 26 Oct 2007 09:30:20 -0700 (PDT) [thread overview]
Message-ID: <alpine.LFD.0.999.0710260929290.30120@woody.linux-foundation.org> (raw)
In-Reply-To: <47221164.10200@ru.mvista.com>
On Fri, 26 Oct 2007, Sergei Shtylyov wrote:
>
> We can just convert cariables declared as 'struct hpt_info' to const too --
> they are read-only templates.
Generally "__devinitdata" is better than "const", since it means that the
data may be thrown away.
So if you drop one over the other, it's generally the "const" that should
be dropped ;/
Linus
next prev parent reply other threads:[~2007-10-26 16:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-26 15:56 Russell King
2007-10-26 16:10 ` Sergei Shtylyov
2007-10-26 16:30 ` Linus Torvalds [this message]
2007-10-26 16:38 ` Sergei Shtylyov
2007-10-26 17:05 ` Arjan van de Ven
2007-10-26 16:12 ` Linus Torvalds
2007-10-26 18:18 ` Bartlomiej Zolnierkiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.0.999.0710260929290.30120@woody.linux-foundation.org \
--to=torvalds@linux-foundation.org \
--cc=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=bzolnier@gmail.com \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rmk@arm.linux.org.uk \
--cc=sshtylyov@ru.mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®