From: Linus Torvalds <torvalds@linux-foundation.org>
To: Zach Brown <zach.brown@oracle.com>
Cc: Karl Schendel <kschendel@datallegro.com>,
Benjamin LaHaise <bcrl@kvack.org>,
Andrew Morton <akpm@linux-foundation.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Nick Piggin <nickpiggin@yahoo.com.au>,
Leonid Ananiev <leonid.i.ananiev@linux.intel.com>,
Chris Mason <chris.mason@oracle.com>
Subject: Re: [PATCH] Fix bad data from non-direct-io read after direct-io write
Date: Fri, 26 Oct 2007 15:42:40 -0700 (PDT) [thread overview]
Message-ID: <alpine.LFD.0.999.0710261541410.30120@woody.linux-foundation.org> (raw)
In-Reply-To: <47226A75.1020008@oracle.com>
On Fri, 26 Oct 2007, Zach Brown wrote:
>
> I think that test should be changed to
How about not testing at all? Which was what the old code did.
Just do the invalidate unconditionally for any writes, and screw the end
result of the invalidate, since we cannot afford to overwrite the previous
return value anyway in any realistic scenario?
Linus
next prev parent reply other threads:[~2007-10-26 22:43 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-26 21:12 Karl Schendel
2007-10-26 21:34 ` Linus Torvalds
2007-10-26 22:10 ` Karl Schendel
2007-10-26 22:30 ` Zach Brown
2007-10-26 22:41 ` Karl Schendel
2007-10-26 22:42 ` Linus Torvalds [this message]
2007-10-26 22:54 ` Zach Brown
2007-10-26 23:14 ` Linus Torvalds
2007-10-26 23:28 ` Karl Schendel
2007-10-30 18:45 ` Zach Brown
2007-10-30 19:11 ` Linus Torvalds
2007-10-26 23:38 ` Zach Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.0.999.0710261541410.30120@woody.linux-foundation.org \
--to=torvalds@linux-foundation.org \
--cc=akpm@linux-foundation.org \
--cc=bcrl@kvack.org \
--cc=chris.mason@oracle.com \
--cc=kschendel@datallegro.com \
--cc=leonid.i.ananiev@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nickpiggin@yahoo.com.au \
--cc=zach.brown@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®