From: Linus Torvalds <torvalds@linux-foundation.org>
To: David Howells <dhowells@redhat.com>
Cc: akpm@linux-foundation.org, rpjday@crashcourse.ca,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] FRV: Permit the memory to be located elsewhere in NOMMU mode
Date: Mon, 29 Oct 2007 09:28:28 -0700 (PDT) [thread overview]
Message-ID: <alpine.LFD.0.999.0710290926140.30120@woody.linux-foundation.org> (raw)
In-Reply-To: <20071029152028.14124.50739.stgit@warthog.procyon.org.uk>
On Mon, 29 Oct 2007, David Howells wrote:
>
> -__page_offset = 0xc0000000; /* start of area covered by struct pages */
> +/* start of area covered by struct pages */
> +#if defined(CONFIG_UCPAGE_OFFSET_20000000)
> +__page_offset = 0x20000000;
> +#elif defined(CONFIG_UCPAGE_OFFSET_40000000)
> +__page_offset = 0x40000000;
...
Please don't do these kinds of things in the source code.
Do them in the Kconfig language where it belongs, and where it makes much
more sense.
See, for example, arch/x86/Kconfig.i386:
config PAGE_OFFSET
hex
default 0xB0000000 if VMSPLIT_3G_OPT
default 0x80000000 if VMSPLIT_2G
default 0x78000000 if VMSPLIT_2G_OPT
default 0x40000000 if VMSPLIT_1G
default 0xC0000000
Notice? Even the syntax is much cleaner!
Linus
next prev parent reply other threads:[~2007-10-29 16:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-29 15:20 David Howells
2007-10-29 16:28 ` Linus Torvalds [this message]
2007-10-29 16:38 ` David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.0.999.0710290926140.30120@woody.linux-foundation.org \
--to=torvalds@linux-foundation.org \
--cc=akpm@linux-foundation.org \
--cc=dhowells@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rpjday@crashcourse.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®