mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Linus Torvalds <torvalds@linux-foundation.org>
To: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>
Cc: Jeff Garzik <jeff@garzik.org>,
	Randy Dunlap <rdunlap@xenotime.net>,
	hch@infradead.org, linux-kernel@vger.kernel.org,
	Sam Ravnborg <sam@ravnborg.org>,
	Jens Axboe <jens.axboe@oracle.com>,
	Prasanna S Panchamukhi <prasanna@in.ibm.com>,
	Ananth N Mavinakayanahalli <ananth@in.ibm.com>,
	Anil S Keshavamurthy <anil.s.keshavamurthy@intel.com>,
	"David S. Miller" <davem@davemloft.net>,
	Ingo Molnar <mingo@redhat.com>,
	Peter Zijlstra <pzijlstr@redhat.com>,
	Philippe Elie <phil.el@wanadoo.fr>,
	"William L. Irwin" <wli@holomorphy.com>,
	Arjan van de Ven <arjan@infradead.org>,
	Christoph Lameter <christoph@lameter.com>,
	Valdis.Kletnieks@vt.edu
Subject: Re: [RFC] Create kinst/ or ki/ directory ?
Date: Tue, 30 Oct 2007 10:50:23 -0700 (PDT)	[thread overview]
Message-ID: <alpine.LFD.0.999.0710301044110.30120@woody.linux-foundation.org> (raw)
In-Reply-To: <20071030172442.GA4477@Krystal>



On Tue, 30 Oct 2007, Mathieu Desnoyers wrote:
>
> * Jeff Garzik (jeff@garzik.org) wrote:
> ...
> > Pick a shorter word like probes or profile or what... or better yet... 
> > just leave most things in their current directories.
> ...
> 
> 
> How about something along the
> 
> kinst or ki
> 
> lines ?
> 
> (for "kernel instrumentation")

No, that's horrible.

Also, in general, why do people want to have an "instrumentation" thing? 
Yes, you can put random things into the same box, but that doesn't make 
them be the same thing. Personally, I don't think "instrumentation" is 
very useful at all. I consider "profiling" and "markers" to be two 
fundamentally different things, and putting them both in the same box does 
not make them any more similar. 

Yes, technically they are both "instrumentation", but hey, technically the 
VM and the VFS layer are both "infrastructure", but we don't put *those* 
in a "infrastructure" subdirectory.

In other words, the fact that two different things share some attribute 
does not mean that they should be collapsed together by that attribute, 
does it?

I think "instrumentation" was/is a particularly bad thing to group things 
by. It doesn't actually tell you anything about the thing, and it's not 
even true that some people are interested in "instrumentation"  and others 
aren't. 

For example: I think profiling support is something REALLY FUNDAMENTAL. 
It's something each and every developer should generally care about, and 
OProfile should be considered an indispensable tool for any developer, on 
par with something like gdb.

In contrast, we should *not* expect most people to do any kernel markers 
etc. That's a very esoteric thing.

So I actually think that the current Kconfig.instrumentation should be 
*removed*. Rather than adding more groupings based on that fundamentally 
flawed premise of false commonality.

		Linus

  parent reply	other threads:[~2007-10-30 17:52 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-29 21:51 [RFC] Create instrumentation directory (git repository) Mathieu Desnoyers
2007-10-29 22:47 ` Randy Dunlap
2007-10-29 22:54   ` Jeff Garzik
2007-10-29 23:04     ` Mathieu Desnoyers
2007-10-29 23:08       ` Jeff Garzik
2007-10-29 23:35         ` Mathieu Desnoyers
2007-10-30  0:47           ` Jeff Garzik
2007-10-30  1:38             ` Mathieu Desnoyers
2007-10-30  9:13           ` Arnaldo Carvalho de Melo
2007-10-30 17:24         ` [RFC] Create kinst/ or ki/ directory ? Mathieu Desnoyers
2007-10-30 17:49           ` Peter Zijlstra
2007-10-30 17:50           ` Linus Torvalds [this message]
2007-10-30 17:58             ` Christoph Hellwig
2007-10-30 18:56             ` Mathieu Desnoyers
2007-10-30 19:25               ` Linus Torvalds
2007-10-30 20:40                 ` Mathieu Desnoyers
2007-10-31 15:48                   ` Frank Ch. Eigler
2007-10-31 16:29                     ` Arjan van de Ven
2007-10-31 19:05                       ` Frank Ch. Eigler
2007-10-31 19:49                         ` Arjan van de Ven
2007-10-31 16:36                     ` Mathieu Desnoyers
2007-10-31 19:29                       ` Frank Ch. Eigler
2007-10-30 21:46               ` Sam Ravnborg
2007-10-29 23:20 ` [RFC] Create instrumentation directory (git repository) Christoph Lameter
2007-10-29 23:40   ` Mathieu Desnoyers
2007-10-29 23:45     ` Christoph Lameter
2007-10-30  0:51     ` Jeff Garzik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LFD.0.999.0710301044110.30120@woody.linux-foundation.org \
    --to=torvalds@linux-foundation.org \
    --cc=Valdis.Kletnieks@vt.edu \
    --cc=ananth@in.ibm.com \
    --cc=anil.s.keshavamurthy@intel.com \
    --cc=arjan@infradead.org \
    --cc=christoph@lameter.com \
    --cc=davem@davemloft.net \
    --cc=hch@infradead.org \
    --cc=jeff@garzik.org \
    --cc=jens.axboe@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mathieu.desnoyers@polymtl.ca \
    --cc=mingo@redhat.com \
    --cc=phil.el@wanadoo.fr \
    --cc=prasanna@in.ibm.com \
    --cc=pzijlstr@redhat.com \
    --cc=rdunlap@xenotime.net \
    --cc=sam@ravnborg.org \
    --cc=wli@holomorphy.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®