From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758489AbXKCCrR (ORCPT ); Fri, 2 Nov 2007 22:47:17 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755733AbXKCCrG (ORCPT ); Fri, 2 Nov 2007 22:47:06 -0400 Received: from smtp2.linux-foundation.org ([207.189.120.14]:50161 "EHLO smtp2.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755747AbXKCCrE (ORCPT ); Fri, 2 Nov 2007 22:47:04 -0400 Date: Fri, 2 Nov 2007 19:46:22 -0700 (PDT) From: Linus Torvalds To: Ralf Baechle cc: Andrew Morton , Thomas Bogendoerfer , Linux Kernel Mailing List , Jay Estabrook , Ivan Kokshaysky , Paul Mackerras Subject: Re: [PATCH] Use i8253.c lock for PC speaker on MIPS, too. In-Reply-To: <20071102172606.GA29513@linux-mips.org> Message-ID: References: <20071102161650.GA28459@linux-mips.org> <20071102172606.GA29513@linux-mips.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2 Nov 2007, Ralf Baechle wrote: > > The Jazz machines have to use the PIT timer for dyntick and highresolution > kernels. This may break because currently just like i386 used to do MIPS > uses two separate spinlocks in the actual PIT code and the PC speaker > code. So switch to do it the same that x86 currently does PIT locking. Hmm. That leaves apparently just alpha/ppc/powerpc as supporting pcspkr, and *not* doing this. Maybe they should be forced to do the i8253 lock in arch code too, and expose it through , instead of having that butt-ugly #ifdef remain in the sources? Paul, Jay, Ivan: right now drivers/input/pcspkr.c does this: #if defined(CONFIG_MIPS) || defined(CONFIG_X86) /* Use the global PIT lock ! */ #include #else #include static DEFINE_SPINLOCK(i8253_lock); #endif and wouldn't it be nice if we just changed it to #include and got rid of one totally unnecessary stupid arch difference? Linus