From: Thomas Gleixner <tglx@linutronix.de>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: LKML <linux-kernel@vger.kernel.org>, Ingo Molnar <mingo@elte.hu>
Subject: Re: [Git pull] arch/x86 updates
Date: Sat, 20 Oct 2007 00:19:25 +0200 (CEST) [thread overview]
Message-ID: <alpine.LFD.0.9999.0710200018170.22770@localhost.localdomain> (raw)
In-Reply-To: <alpine.LFD.0.999.0710191459340.26902@woody.linux-foundation.org>
On Fri, 19 Oct 2007, Linus Torvalds wrote:
>>
> > Pavel Emelyanov (1):
> > i386: consolidate show_regs and show_registers for i386
>
> While I think this is good otherwise, why does it do
>
> printk(".. comm: %.*s .."
> TASK_COMM_LEN, current->comm,
>
> instead of just using "%s" and "current->comm"? I only noticed because
> there was an unrelated conflict around that thing.
>
> That "current->comm" had better be NUL-terminated already, we use it as
> such all over the place. And if it's not, *that* should be fixed.
Fair enough. Did not notice.
tglx
next prev parent reply other threads:[~2007-10-19 22:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-19 21:46 Thomas Gleixner
2007-10-19 22:04 ` Linus Torvalds
2007-10-19 22:19 ` Thomas Gleixner [this message]
2007-10-19 23:14 ` Ingo Molnar
-- strict thread matches above, loose matches on Subject: below --
2007-10-17 20:05 Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.0.9999.0710200018170.22770@localhost.localdomain \
--to=tglx@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®