mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: "Pallipadi, Venkatesh" <venkatesh.pallipadi@intel.com>
Cc: Adrian Bunk <bunk@kernel.org>, "Brown, Len" <len.brown@intel.com>,
	LKML <linux-kernel@vger.kernel.org>
Subject: RE: [2.6 patch] unexport tick_nohz_get_sleep_length
Date: Thu, 25 Oct 2007 18:56:52 +0200 (CEST)	[thread overview]
Message-ID: <alpine.LFD.0.9999.0710251855510.3186@localhost.localdomain> (raw)
In-Reply-To: <653FFBB4508B9042B5D43DC9E18836F5018EBEF1@scsmsx415.amr.corp.intel.com>

On Thu, 25 Oct 2007, Pallipadi, Venkatesh wrote:
> >On Wed, 24 Oct 2007, Adrian Bunk wrote:
> >
> >> This patch removes the unused 
> >> EXPORT_SYMBOL_GPL(tick_nohz_get_sleep_length).
> >> 
> >> Signed-off-by: Adrian Bunk <bunk@kernel.org>
> >> 
> >> ---
> >> f7c83dfe117f4fd072b2506ae090e4145abda362 
> >> diff --git a/kernel/time/tick-sched.c b/kernel/time/tick-sched.c
> >> index 10a1347..5997456 100644
> >> --- a/kernel/time/tick-sched.c
> >> +++ b/kernel/time/tick-sched.c
> >> @@ -320,8 +320,6 @@ ktime_t tick_nohz_get_sleep_length(void)
> >>  	return ts->sleep_length;
> >>  }
> >>  
> >> -EXPORT_SYMBOL_GPL(tick_nohz_get_sleep_length);
> >> -
> >
> >Hmm, this was added to allow the cpuidle governers modular
> >build. Seems this was changed to compiled in only.
> >
> >Len, Venki, is this the final decision ?
> >
> 
> Yes. This was done recently for proper fallback to old ACPI policy in
> case CPUIDLE is not selected. With that being module, falling back to
> ACPI policy at run time makes things ugly.

Makes sense. I go ahead and nuke the export.

Thanks,

	tglx

  reply	other threads:[~2007-10-25 16:57 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-24 16:24 Adrian Bunk
2007-10-25  9:28 ` Thomas Gleixner
2007-10-25 16:51   ` Pallipadi, Venkatesh
2007-10-25 16:56     ` Thomas Gleixner [this message]
2007-10-25 21:40       ` Len Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LFD.0.9999.0710251855510.3186@localhost.localdomain \
    --to=tglx@linutronix.de \
    --cc=bunk@kernel.org \
    --cc=len.brown@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=venkatesh.pallipadi@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®