mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>
Cc: Arjan van de Ven <arjan@infradead.org>,
	vgoyal@in.ibm.com, hbabu@us.ibm.com,
	linux-kernel@vger.kernel.org, kexec@lists.infradead.org,
	"Eric W. Biederman" <ebiederm@xmission.com>
Subject: Re: [PATCH] Revert x86: add lapic_shutdown for x86_64
Date: Tue, 30 Oct 2007 02:06:43 +0100 (CET)	[thread overview]
Message-ID: <alpine.LFD.0.9999.0710300203040.3186@localhost.localdomain> (raw)
In-Reply-To: <4726753D.3010601@ct.jp.nec.com>

On Mon, 29 Oct 2007, Hiroshi Shimamoto wrote:

> Arjan van de Ven wrote:
> > On Mon, 29 Oct 2007 15:39:46 -0700
> > Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com> wrote:
> > 
> >> lapic_shutdown is useless on x86_64.
> >>
> > 
> > .... but since the goal is to get apic_32.c and apic_64.c to be more
> > converging (to the point of becoming the same file)... isn't your patch
> > going in the opposite direction?
> > 
> Hmm, I'm not sure that this revert affects x86 unification.
> Vivek said that probably we don't have to introduce lapic_shutdown() for 64bit.
> So I submitted this patch which reverts my previous post, it was applied before
> the comment.

Don't worry, we sort this out. There is some inevitable friction loss
for now, but we are getting closer. I gave the apic code some care to
get a readable diff out of it. Result is in:

git://git.kernel.org/pub/scm/linux/kernel/git/x86/linux-2.6-x86.git cleanup

Thanks,

	tglx

  reply	other threads:[~2007-10-30  1:08 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-20  1:18 [PATCH 0/3] x86: unify crash_32/64.c Hiroshi Shimamoto
2007-10-20  1:21 ` [PATCH 1/3] x86: add lapic_shutdown for x86_64 Hiroshi Shimamoto
2007-10-24  6:29   ` Vivek Goyal
2007-10-24 21:27     ` Hiroshi Shimamoto
2007-10-25  0:28       ` Eric W. Biederman
2007-10-29 22:45         ` Hiroshi Shimamoto
2007-10-29 22:39     ` [PATCH] Revert " Hiroshi Shimamoto
2007-10-29 23:15       ` Arjan van de Ven
2007-10-30  0:05         ` Hiroshi Shimamoto
2007-10-30  1:06           ` Thomas Gleixner [this message]
2007-10-20  1:23 ` [PATCH 2/3] x86: add safe_smp_processor_id " Hiroshi Shimamoto
2007-10-24  6:31   ` Vivek Goyal
2007-10-24  9:01     ` Vivek Goyal
2007-10-20  1:24 ` [PATCH 3/3] x86: unify crash_32/64.c Hiroshi Shimamoto
2007-10-20 10:50 ` [PATCH 0/3] " Thomas Gleixner
2007-10-24  6:34 ` Vivek Goyal
2007-10-24 16:28   ` Hiroshi Shimamoto
2007-10-25 17:58     ` Hiroshi Shimamoto
2007-10-26 21:43       ` Hiroshi Shimamoto
2007-10-26 22:37         ` Thomas Gleixner
2007-10-27  0:13           ` Hiroshi Shimamoto
2007-10-27  1:15             ` Hiroshi Shimamoto

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LFD.0.9999.0710300203040.3186@localhost.localdomain \
    --to=tglx@linutronix.de \
    --cc=arjan@infradead.org \
    --cc=ebiederm@xmission.com \
    --cc=h-shimamoto@ct.jp.nec.com \
    --cc=hbabu@us.ibm.com \
    --cc=kexec@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=vgoyal@in.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®