From: Thomas Gleixner <tglx@linutronix.de>
To: Paul Jimenez <pj@place.org>
Cc: linux-kernel@vger.kernel.org, mingo@redhat.com, hpa@zytor.com
Subject: Re: [PATCH] KJ: Make i8259_64 more _32-like
Date: Tue, 30 Oct 2007 10:00:30 +0100 (CET) [thread overview]
Message-ID: <alpine.LFD.0.9999.0710300959100.3186@localhost.localdomain> (raw)
In-Reply-To: <20071030064050.C401D8B2B@place.org>
On Tue, 30 Oct 2007, Paul Jimenez wrote:
>
> Howdy! Here's a simple janitorish patch for you:
>
> This patch mainly hinges around two includes and their ramifications:
>
> #include <i8259.h> which provides cached_{slave,master}_mask
> #include <io_ports.h> which provides PIC_{MASTER,SLAVE}_{IMR,CMD}
>
> Adding these two includes and using those half dozen or so definitions
> removed 140+ lines of diffs between i8259_32.c and i8259_64.c, thus
> making it easier for the real substantitive differences between them to
> show up, and hopefully therefore making it easier to eventually merge
> the two.
Looks good. Can you please resend with a proper Signed-off-by ?
Run your patch through scripts/checkpatch.pl before sending it out :)
tglx
next prev parent reply other threads:[~2007-10-30 9:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-30 6:40 Paul Jimenez
2007-10-30 9:00 ` Thomas Gleixner [this message]
2007-10-30 15:29 ` Paul Jimenez
2007-11-06 9:29 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.0.9999.0710300959100.3186@localhost.localdomain \
--to=tglx@linutronix.de \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=pj@place.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®