From: Thomas Gleixner <tglx@linutronix.de>
To: Don Zickus <dzickus@redhat.com>
Cc: Arjan van de Ven <arjan@infradead.org>,
linux-kernel@vger.kernel.org, mingo@redhat.com
Subject: Re: [PATCH] Add the word 'Warning' in check_nmi_watchdog() output
Date: Wed, 21 Nov 2007 21:41:25 +0100 (CET) [thread overview]
Message-ID: <alpine.LFD.0.9999.0711212137380.25057@localhost.localdomain> (raw)
In-Reply-To: <20071121184403.GD12071@redhat.com>
On Wed, 21 Nov 2007, Don Zickus wrote:
> On Wed, Nov 21, 2007 at 10:34:59AM -0800, Arjan van de Ven wrote:
> > On Wed, 21 Nov 2007 12:14:20 -0500
> > Don Zickus <dzickus@redhat.com> wrote:
> >
> > > Our automated test suite looks for keywords like error, fail, warning
> > > in the boot log. In the case when the nmi watchdog is determined to
> > > be stuck in check_nmi_watchdog(), none of those keywords are
> > > displayed.
> >
> >
> > please make it at least consistent with the other kernel level bad
> > things, and use "WARNING:"....
>
> Good point. I'll repost.
Before you repost, please add an appropriate KERN_WARN prefix to the
printk and run your patch through scripts/checkpatch.pl.
tglx
prev parent reply other threads:[~2007-11-21 20:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-21 17:14 Don Zickus
2007-11-21 18:34 ` Arjan van de Ven
2007-11-21 18:44 ` Don Zickus
2007-11-21 20:41 ` Thomas Gleixner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.0.9999.0711212137380.25057@localhost.localdomain \
--to=tglx@linutronix.de \
--cc=arjan@infradead.org \
--cc=dzickus@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®