From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756995AbXLDVRb (ORCPT ); Tue, 4 Dec 2007 16:17:31 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755664AbXLDVKl (ORCPT ); Tue, 4 Dec 2007 16:10:41 -0500 Received: from smtp2.linux-foundation.org ([207.189.120.14]:33831 "EHLO smtp2.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755563AbXLDVKh (ORCPT ); Tue, 4 Dec 2007 16:10:37 -0500 Date: Tue, 4 Dec 2007 13:09:36 -0800 (PST) From: Linus Torvalds To: Steven Rostedt cc: Ingo Molnar , Thomas Gleixner , LKML , David Holmes - Sun Microsystems , Andrew Morton Subject: Re: [PATCH] fix for futex_wait signal stack corruption In-Reply-To: <1196801858.1645.37.camel@localhost.localdomain> Message-ID: References: <1196801858.1645.37.camel@localhost.localdomain> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 4 Dec 2007, Steven Rostedt wrote: > > The solution I did to solve this is to allocate a temporary buffer when > setting up the block and free it in futex_wait_restart. This patch > allows David's test program to actually pass. No. Unacceptable. This is a memory leak in case nobody retries it. It's basically not how you can do this thing. The *only* thing you can pass for a system call restart is the argument block register state. If that is not enough, then you cannot restart it. It's that simple. Andrew, please do *not* put this in any queues. It's fundamentally broken, and cannot be fixed as is. Linus