From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752791AbXLEBrX (ORCPT ); Tue, 4 Dec 2007 20:47:23 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751242AbXLEBrQ (ORCPT ); Tue, 4 Dec 2007 20:47:16 -0500 Received: from smtp2.linux-foundation.org ([207.189.120.14]:52903 "EHLO smtp2.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750996AbXLEBrP (ORCPT ); Tue, 4 Dec 2007 20:47:15 -0500 Date: Tue, 4 Dec 2007 17:46:13 -0800 (PST) From: Linus Torvalds To: Steven Rostedt cc: Ingo Molnar , Thomas Gleixner , LKML , David Holmes - Sun Microsystems , Andrew Morton Subject: Re: [PATCH] fix for futex_wait signal stack corruption In-Reply-To: Message-ID: References: <1196801858.1645.37.camel@localhost.localdomain> <20071204213924.GA14915@goodmis.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 4 Dec 2007, Steven Rostedt wrote: > > Since arg3 is out, which do you prefer? Creating an arg4 (and perhaps > more) in the block or having a u64 arg? Changing all the args to u64 may > be the best. I suspect that the best option is probably to make that thing a unnamed union of the actual different types the different restart cases needs, which also allows you to name things appropriately and not have any wasted space. Leave the arg0-3 ones around as one of the unions, both to avoid having to change other things and to have a "generic" one for stuff that simply doesn't much care (in order to not have tons and tons of substructures to the union when most users really don't need any fancy types). I think we already depend on recent-enough gcc's that unnamed unions are ok and we don't need to play games with naming. Linus