From: Thomas Gleixner <tglx@linutronix.de>
To: Andi Kleen <ak@suse.de>
Cc: "Huang, Ying" <ying.huang@intel.com>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/5] x86: change_page_attr_clear fix
Date: Thu, 31 Jan 2008 13:38:45 +0100 (CET) [thread overview]
Message-ID: <alpine.LFD.1.00.0801311333170.9204@apollo.tec.linutronix.de> (raw)
In-Reply-To: <200801310843.46831.ak@suse.de>
On Thu, 31 Jan 2008, Andi Kleen wrote:
> On Thursday 31 January 2008 08:35:59 Huang, Ying wrote:
> > This patch replaces __change_page_attr_set_clr() with
> > change_page_attr_set_clr() in change_page_attr_clear() to flush the
> > TLB/cache properly.
>
> Good catch :-) It actually only needs to flush TLBs not caches in this
> case.
That's one of the items on our optimizations todo list already. There
are more low hanging fruits, but we need to make sure that the non
optimized version is bullet proof first.
Thanks,
tglx
next prev parent reply other threads:[~2008-01-31 12:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-31 7:35 Huang, Ying
2008-01-31 7:43 ` Andi Kleen
2008-01-31 12:38 ` Thomas Gleixner [this message]
2008-01-31 12:53 ` Andi Kleen
2008-01-31 12:10 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.1.00.0801311333170.9204@apollo.tec.linutronix.de \
--to=tglx@linutronix.de \
--cc=ak@suse.de \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®