From: Thomas Gleixner <tglx@linutronix.de>
To: Andi Kleen <ak@suse.de>
Cc: huang ying <huang.ying.caritas@gmail.com>,
"Huang, Ying" <ying.huang@intel.com>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/5] x86: add executable mapping support to ioremap
Date: Thu, 31 Jan 2008 17:30:27 +0100 (CET) [thread overview]
Message-ID: <alpine.LFD.1.00.0801311728430.9204@apollo.tec.linutronix.de> (raw)
In-Reply-To: <200801311427.38198.ak@suse.de>
On Thu, 31 Jan 2008, Andi Kleen wrote:
> > addr = ioremap(phys_addr, len);
> > set_memory_x(addr);
> > if (phys_addr < (end_pfn_mapped >> PAGE_SHIFT))
> > set_memory_x(__va(phys_addr));
>
> If you just need the ioremap executable there is no reason to split
> up the direct mapping for this too. The x86 architecture does not require
> x bits to be coherent between mappings; only the caching attributes.
Thanks for pointing this out.
tglx
next prev parent reply other threads:[~2008-01-31 16:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-31 7:36 Huang, Ying
2008-01-31 13:00 ` Thomas Gleixner
2008-01-31 13:22 ` huang ying
2008-01-31 13:27 ` Andi Kleen
2008-01-31 16:30 ` Thomas Gleixner [this message]
2008-01-31 16:28 ` Thomas Gleixner
2008-01-31 16:30 ` Andi Kleen
2008-01-31 16:37 ` Thomas Gleixner
2008-01-31 16:44 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.1.00.0801311728430.9204@apollo.tec.linutronix.de \
--to=tglx@linutronix.de \
--cc=ak@suse.de \
--cc=hpa@zytor.com \
--cc=huang.ying.caritas@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®