From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759042AbYBSQw2 (ORCPT ); Tue, 19 Feb 2008 11:52:28 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1757896AbYBSQwL (ORCPT ); Tue, 19 Feb 2008 11:52:11 -0500 Received: from www.tglx.de ([62.245.132.106]:56483 "EHLO www.tglx.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757468AbYBSQwK (ORCPT ); Tue, 19 Feb 2008 11:52:10 -0500 Date: Tue, 19 Feb 2008 17:51:01 +0100 (CET) From: Thomas Gleixner To: Ingo Molnar cc: Pavel Machek , Len Brown , Linux-pm mailing list , jbohac@suse.cz, kernel list , jikos@suse.cz, "Rafael J. Wysocki" , Andrew Morton Subject: Re: tsc breaks atkbd suspend In-Reply-To: <20080219140552.GC9965@elte.hu> Message-ID: References: <20080218133852.GA1573@elf.ucw.cz> <20080218143757.GB1960@elf.ucw.cz> <20080219100029.GA1637@elf.ucw.cz> <20080219140552.GC9965@elte.hu> User-Agent: Alpine 1.00 (LFD 882 2007-12-20) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 19 Feb 2008, Ingo Molnar wrote: > * Pavel Machek wrote: > > > TSC is used even on machines when CONFIG_X86_TSC is not set (X86_TSC > > means _require_ TSC), but it is not properly disabled when it is > > unusable, because acpi code understood the config switch as "may use > > TSC". > > > > This actually fixes suspend problems on my x60. > > ah! This makes tons of sense. I've applied your patch - but i guess it > should go via the ACPI tree. Right. The breakage was introduced there when IA64 switched to GENERIC_TIME and the X86_TSC dependency was added. Thanks, tglx