From: Linus Torvalds <torvalds@linux-foundation.org>
To: Nick Piggin <nickpiggin@yahoo.com.au>
Cc: Jeff Garzik <jeff@garzik.org>, Roland McGrath <roland@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] genhd must_check warning fix
Date: Wed, 12 Mar 2008 08:05:45 -0700 (PDT) [thread overview]
Message-ID: <alpine.LFD.1.00.0803120803530.12341@woody.linux-foundation.org> (raw)
In-Reply-To: <200803121507.39347.nickpiggin@yahoo.com.au>
On Wed, 12 Mar 2008, Nick Piggin wrote:
>
> If you tune out the must_check warnings, then how is that better than
> not having them at all? In either case, you'd have missed this genhd
> bug(let).
Quite frankly, there have historically been too many people who just added
"must_check" to their function prototypes because they thought they were
oh-so-important. Which means that at least _I_ tend to just ignore them
(and have asked people to remove some when they get too annoying).
So I'm not at all surprised that people tune them out. They have become
debased by being overused.
Linus
prev parent reply other threads:[~2008-03-12 15:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-12 0:13 Roland McGrath
2008-03-12 3:25 ` Jeff Garzik
2008-03-12 3:40 ` Nick Piggin
2008-03-12 3:53 ` Jeff Garzik
2008-03-12 4:07 ` Nick Piggin
2008-03-12 15:05 ` Linus Torvalds [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.1.00.0803120803530.12341@woody.linux-foundation.org \
--to=torvalds@linux-foundation.org \
--cc=akpm@linux-foundation.org \
--cc=jeff@garzik.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nickpiggin@yahoo.com.au \
--cc=roland@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®