From: Linus Torvalds <torvalds@linux-foundation.org>
To: Johannes Weiner <hannes@saeurebad.de>
Cc: Dave Young <hidave.darkstar@gmail.com>,
akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
Marcin Slusarz <marcin.slusarz@gmail.com>,
paulmck@linux.vnet.ibm.com
Subject: Re: [PATCH -mm] do not check condition twice in WARN_ON_SECS
Date: Wed, 12 Mar 2008 21:47:52 -0700 (PDT) [thread overview]
Message-ID: <alpine.LFD.1.00.0803122147260.3557@woody.linux-foundation.org> (raw)
In-Reply-To: <87pru0oxyv.fsf@saeurebad.de>
On Wed, 12 Mar 2008, Johannes Weiner wrote:
>
> What's wrong with:
>
> #define WARN_ON_SECS(condition, secs) \
> WARN_ON(condition && __ratelimit(secs * HZ, 1))
Add parenthesis around the arguments, please.
Linus
prev parent reply other threads:[~2008-03-13 4:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-12 1:09 Dave Young
2008-03-12 13:47 ` Johannes Weiner
2008-03-13 0:44 ` Dave Young
2008-03-13 4:47 ` Linus Torvalds [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.1.00.0803122147260.3557@woody.linux-foundation.org \
--to=torvalds@linux-foundation.org \
--cc=akpm@linux-foundation.org \
--cc=hannes@saeurebad.de \
--cc=hidave.darkstar@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marcin.slusarz@gmail.com \
--cc=paulmck@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®