mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Robert P. J. Day" <rpjday@crashcourse.ca>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: Jan Engelhardt <jengelh@computergmbh.de>,
	Jesper Juhl <jesper.juhl@gmail.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: whose job is it to include various header files?
Date: Fri, 14 Mar 2008 04:01:52 -0400 (EDT)	[thread overview]
Message-ID: <alpine.LFD.1.00.0803140359560.31711@localhost.localdomain> (raw)
In-Reply-To: <20080314054744.GA4216@martell.zuzino.mipt.ru>

On Fri, 14 Mar 2008, Alexey Dobriyan wrote:

> On Thu, Mar 13, 2008 at 09:53:01PM -0400, Robert P. J. Day wrote:

> > includes from <linux/percpu.h>:
> >
> >   #include <linux/slab.h>
>
> This needed for kzalloc().

oh, &%^^%*(&^), you're right.  i looked at the comment, where it said
it needed that include for "kmalloc", grepped, didn't see kmalloc so
thought that include was unnecessary.  i didn't even notice the
"kzalloc".  my bad, profuse apologies.  argh.

rday
--


========================================================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry:
    Have classroom, will lecture.

http://crashcourse.ca                          Waterloo, Ontario, CANADA
========================================================================

  reply	other threads:[~2008-03-14  8:02 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-13 22:09 Robert P. J. Day
2008-03-13 22:46 ` Randy Dunlap
2008-03-13 23:53 ` Jesper Juhl
2008-03-14  1:02   ` Robert P. J. Day
2008-03-14  1:36   ` Jan Engelhardt
2008-03-14  1:53     ` Robert P. J. Day
2008-03-14  5:47       ` Alexey Dobriyan
2008-03-14  8:01         ` Robert P. J. Day [this message]
2008-03-14  6:47   ` mws
2008-03-14  8:07     ` Robert P. J. Day
2008-03-14  9:29       ` Robert P. J. Day

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LFD.1.00.0803140359560.31711@localhost.localdomain \
    --to=rpjday@crashcourse.ca \
    --cc=adobriyan@gmail.com \
    --cc=jengelh@computergmbh.de \
    --cc=jesper.juhl@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®