From: Linus Torvalds <torvalds@linux-foundation.org>
To: Al Viro <viro@ZenIV.linux.org.uk>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [git pull] vfs patches
Date: Tue, 25 Mar 2008 09:05:59 -0700 (PDT) [thread overview]
Message-ID: <alpine.LFD.1.00.0803250859330.2775@woody.linux-foundation.org> (raw)
In-Reply-To: <20080325081752.GJ10722@ZenIV.linux.org.uk>
On Tue, 25 Mar 2008, Al Viro wrote:
>
> misc VFS fixes for 2.6.25. Please pull from
> git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs-2.6.git/ for-linus
Pulled.
And looking at the diffs, I see sequences like
dget(save.dentry);
mntget(save.mnt);
...
path_put(&save);
which looks very strange compared to the natural sequence:
path_get(&save);
..
path_put(&save);
and yes, I realize the code was just moved (and the reason for the mixing
is that the "path_put()" conversion was done much more aggressively, as
the ordering matters), but I'm bringing this up in the hope somebody has
the energy to clean things like up some day...
Linus
next prev parent reply other threads:[~2008-03-25 16:06 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-25 8:17 Al Viro
2008-03-25 16:05 ` Linus Torvalds [this message]
2008-03-25 18:00 ` Al Viro
2008-04-26 2:02 [git pull] VFS patches Al Viro
2008-04-26 11:01 ` Ingo Molnar
2008-04-26 13:35 ` Matthew Wilcox
2008-04-26 13:44 ` Ingo Molnar
2008-04-26 15:43 ` Ingo Molnar
2008-04-26 19:02 ` Mike Galbraith
2008-05-20 12:04 ` hooanon05
2008-05-17 7:19 [git pull] vfs patches Al Viro
2008-06-25 3:32 Al Viro
2008-08-01 15:36 Al Viro
2008-08-03 14:08 ` Roland Dreier
2008-08-03 14:53 ` Al Viro
2008-10-23 9:52 Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.1.00.0803250859330.2775@woody.linux-foundation.org \
--to=torvalds@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®