From: Linus Torvalds <torvalds@linux-foundation.org>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Greg KH <greg@kroah.com>, Bj?rn Steinbrink <B.Steinbrink@gmx.de>,
Arjan van de Ven <arjan@linux.intel.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Johannes Berg <johannes@sipsolutions.net>,
Jiri Kosina <jkosina@suse.cz>
Subject: Re: [PATCH] evdev: Release eventual input device grabs when getting disconnected
Date: Mon, 31 Mar 2008 11:24:20 -0700 (PDT) [thread overview]
Message-ID: <alpine.LFD.1.00.0803311122040.14670@woody.linux-foundation.org> (raw)
In-Reply-To: <20080331135653.ZZRA012@mailhub.coreip.homeip.net>
On Mon, 31 Mar 2008, Dmitry Torokhov wrote:
>
> Greg, please look at the change again. Before kobject_put(kobj->parent)
> was done in kobject_cleanup() and so the parent would only be freed when
> all its children are gone. Now parent is deleted early, even if its
> children are still referenced by other users. This is lifetime rule
> change and should really be announced as such.
>
> If this change it intentional and is here to stay then I will just grab
> the references myself, although I wonder what else might be broken by
> it.
I do agree that this might want reverting, unless there is some rally good
reason for it. People may have pefectly valid reasons to expect topology
and reachability to remain valid - it's certainly what we guarantee in the
VFS code for similar rules (ie the parent of a dentry is only free'd after
all children have gone away).
Greg, is it possible to get the old lifetime rules back wrt his? They seem
valid and sane..
Linus
next prev parent reply other threads:[~2008-03-31 18:25 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-30 18:42 Björn Steinbrink
2008-03-30 21:51 ` Linus Torvalds
2008-03-30 22:22 ` Greg KH
2008-03-30 22:35 ` Linus Torvalds
2008-03-30 22:42 ` Björn Steinbrink
2008-03-30 23:19 ` Arjan van de Ven
2008-03-31 20:46 ` Dmitry Torokhov
2008-03-31 6:15 ` Dmitry Torokhov
2008-03-31 17:28 ` Greg KH
2008-03-31 18:01 ` Dmitry Torokhov
2008-03-31 18:24 ` Linus Torvalds [this message]
2008-03-31 23:12 ` Benjamin Herrenschmidt
2008-03-31 23:51 ` Greg KH
2008-04-01 1:01 ` Benjamin Herrenschmidt
2008-03-31 20:42 ` Greg KH
2008-03-31 20:57 ` Dmitry Torokhov
2008-03-31 22:09 ` Greg KH
2008-04-01 3:30 ` Dmitry Torokhov
2008-03-31 21:27 ` Jiri Kosina
2008-03-31 22:46 ` Kay Sievers
2008-03-31 20:21 ` Johannes Berg
2008-03-31 19:05 ` Björn Steinbrink
2008-04-01 11:51 ` Johannes Berg
2008-04-01 15:20 ` Björn Steinbrink
2008-04-02 9:17 ` Johannes Berg
2008-03-31 21:02 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.1.00.0803311122040.14670@woody.linux-foundation.org \
--to=torvalds@linux-foundation.org \
--cc=B.Steinbrink@gmx.de \
--cc=arjan@linux.intel.com \
--cc=dmitry.torokhov@gmail.com \
--cc=greg@kroah.com \
--cc=jkosina@suse.cz \
--cc=johannes@sipsolutions.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®