mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Robert P. J. Day" <rpjday@crashcourse.ca>
To: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Cc: Andrew Morton <akpm@osdl.org>
Subject: [PATCH] Drop an empty byteorder/generic.h from being exported to userspace.
Date: Tue, 1 Apr 2008 21:38:20 -0400 (EDT)	[thread overview]
Message-ID: <alpine.LFD.1.00.0804012134300.10852@localhost.localdomain> (raw)


Since the entire meaningful contents of generic.h is wrapped by the
__KERNEL__ test, drop it from being passed to userspace, and remove
the now superfluous __KERNEL__ test.

Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>

---

  is there some value in allowing an effectively empty header file to
be exported to userspace?

 include/linux/byteorder/Kbuild    |    1 -
 include/linux/byteorder/generic.h |    8 --------
 2 files changed, 9 deletions(-)

diff --git a/include/linux/byteorder/Kbuild b/include/linux/byteorder/Kbuild
index 79beddd..a50614c 100644
--- a/include/linux/byteorder/Kbuild
+++ b/include/linux/byteorder/Kbuild
@@ -1,5 +1,4 @@
 header-y += big_endian.h
 header-y += little_endian.h

-unifdef-y += generic.h
 unifdef-y += swab.h
diff --git a/include/linux/byteorder/generic.h b/include/linux/byteorder/generic.h
index d377155..0846e6b 100644
--- a/include/linux/byteorder/generic.h
+++ b/include/linux/byteorder/generic.h
@@ -82,12 +82,6 @@
  *
  */

-
-#if defined(__KERNEL__)
-/*
- * inside the kernel, we can use nicknames;
- * outside of it, we must avoid POSIX namespace pollution...
- */
 #define cpu_to_le64 __cpu_to_le64
 #define le64_to_cpu __le64_to_cpu
 #define cpu_to_le32 __cpu_to_le32
@@ -176,6 +170,4 @@ static inline void be64_add_cpu(__be64 *var, u64 val)
 	*var = cpu_to_be64(be64_to_cpu(*var) + val);
 }

-#endif /* KERNEL */
-
 #endif /* _LINUX_BYTEORDER_GENERIC_H */
========================================================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry:
    Have classroom, will lecture.

http://crashcourse.ca                          Waterloo, Ontario, CANADA
========================================================================

             reply	other threads:[~2008-04-02  1:38 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-02  1:38 Robert P. J. Day [this message]
2008-04-02 10:20 ` Jiri Slaby
2008-04-02 11:00   ` Robert P. J. Day
2008-04-02 11:01     ` Jiri Slaby
2008-04-02 11:02       ` Robert P. J. Day

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LFD.1.00.0804012134300.10852@localhost.localdomain \
    --to=rpjday@crashcourse.ca \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®