From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1763015AbYDNWxN (ORCPT ); Mon, 14 Apr 2008 18:53:13 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1761810AbYDNWuN (ORCPT ); Mon, 14 Apr 2008 18:50:13 -0400 Received: from smtp1.linux-foundation.org ([140.211.169.13]:38795 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1763010AbYDNWuI (ORCPT ); Mon, 14 Apr 2008 18:50:08 -0400 Date: Mon, 14 Apr 2008 15:48:51 -0700 (PDT) From: Linus Torvalds To: Davide Libenzi cc: Linux Kernel Mailing List , Andrew Morton , Arnd Bergmann , Al Viro , Michael Kerrisk , Christoph Hellwig Subject: Re: [patch] F_GETPATH implementation In-Reply-To: Message-ID: References: User-Agent: Alpine 1.00 (LFD 882 2007-12-20) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 14 Apr 2008, Davide Libenzi wrote: > Index: linux-2.6.mod/include/asm-generic/fcntl.h > =================================================================== > --- linux-2.6.mod.orig/include/asm-generic/fcntl.h 2008-04-13 15:01:09.000000000 -0700 > +++ linux-2.6.mod/include/asm-generic/fcntl.h 2008-04-13 18:37:35.000000000 -0700 > @@ -73,6 +73,7 @@ > #define F_SETSIG 10 /* for sockets. */ > #define F_GETSIG 11 /* for sockets. */ > #endif > +#define F_GETPATH 12 This won't work. Different architectures have different F_xyzzy numbers, and 12 is already used by various ones (it's F_SETOWN in asm-parisc/fcntl.h, for example). I think you'd have to do it in terms of F_LINUX_SPECIFIC_BASE, like F_NOTIFY is done, for example. That way you avoid these issues. Linus