From: Linus Torvalds <torvalds@linux-foundation.org>
To: David Howells <dhowells@redhat.com>
Cc: akpm@linux-foundation.org, viro@zeniv.linux.org.uk,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] RxRPC: Fix a regression in the RXKAD security module
Date: Thu, 24 Apr 2008 13:45:51 -0700 (PDT) [thread overview]
Message-ID: <alpine.LFD.1.10.0804241248290.2779@woody.linux-foundation.org> (raw)
In-Reply-To: <20080424193856.14737.16718.stgit@warthog.procyon.org.uk>
On Thu, 24 Apr 2008, David Howells wrote:
>
> Fix a regression in the RXKAD security module introduced in:
>
> commit 91e916cffec7c0153c5cbaa447151862a7a9a047
> Author: Al Viro <viro@ftp.linux.org.uk>
> Date: Sat Mar 29 03:08:38 2008 +0000
>
> net/rxrpc trivial annotations
>
> A variable was declared as a 16-bit type rather than a 32-bit type.
Ok, that looks stupid, and should even have had a warning (shifting a u16
right by 16 should warn about it being pointless, but doesn't, because the
compiler quietly expands it to "int" in the meantime).
Hmm. I could do something to sparse that warns about that too.
Linus
prev parent reply other threads:[~2008-04-24 20:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-24 19:38 David Howells
2008-04-24 20:21 ` Al Viro
2008-04-24 20:45 ` Linus Torvalds [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.1.10.0804241248290.2779@woody.linux-foundation.org \
--to=torvalds@linux-foundation.org \
--cc=akpm@linux-foundation.org \
--cc=dhowells@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®