mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Robert P. J. Day" <rpjday@crashcourse.ca>
To: trivial@kernel.org
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: [PATCH] SYSFS: Correct misleading documentation in params.c.
Date: Fri, 25 Apr 2008 12:46:20 -0400 (EDT)	[thread overview]
Message-ID: <alpine.LFD.1.10.0804251244070.14768@localhost.localdomain> (raw)


A couple comment fixes related to creating module parameter files
under /sys.

Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>

---

  i have no idea what means that reference to symlinks to
/sys/parameters.  something long since gone away?

diff --git a/kernel/params.c b/kernel/params.c
index afc46a2..52ac726 100644
--- a/kernel/params.c
+++ b/kernel/params.c
@@ -372,7 +372,7 @@ int param_get_string(char *buffer, struct kernel_param *kp)
 	return strlcpy(buffer, kps->string, kps->maxlen);
 }

-/* sysfs output in /sys/modules/XYZ/parameters/ */
+/* sysfs output in /sys/module/XYZ/parameters/ */

 extern struct kernel_param __start___param[], __stop___param[];

@@ -506,8 +506,7 @@ param_sysfs_setup(struct module_kobject *mk,
  * @kparam: module parameters (array)
  * @num_params: number of module parameters
  *
- * Adds sysfs entries for module parameters, and creates a link from
- * /sys/module/[mod->name]/parameters to /sys/parameters/[mod->name]/
+ * Adds sysfs entries for module parameters.
  */
 int module_param_sysfs_setup(struct module *mod,
 			     struct kernel_param *kparam,
@@ -572,7 +571,7 @@ static void __init kernel_param_sysfs_setup(const char *name,
 }

 /*
- * param_sysfs_builtin - add contents in /sys/parameters for built-in modules
+ * param_sysfs_builtin - add contents under /sys for built-in modules
  *
  * Add module_parameters to sysfs for "modules" built into the kernel.
  *

========================================================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry:
    Have classroom, will lecture.

http://crashcourse.ca                          Waterloo, Ontario, CANADA
========================================================================

                 reply	other threads:[~2008-04-25 16:46 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LFD.1.10.0804251244070.14768@localhost.localdomain \
    --to=rpjday@crashcourse.ca \
    --cc=linux-kernel@vger.kernel.org \
    --cc=trivial@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®