From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759696AbYDZREj (ORCPT ); Sat, 26 Apr 2008 13:04:39 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1758504AbYDZREa (ORCPT ); Sat, 26 Apr 2008 13:04:30 -0400 Received: from smtp1.linux-foundation.org ([140.211.169.13]:38106 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758379AbYDZRE3 (ORCPT ); Sat, 26 Apr 2008 13:04:29 -0400 Date: Sat, 26 Apr 2008 10:03:31 -0700 (PDT) From: Linus Torvalds To: Ingo Molnar cc: Linux Kernel Mailing List , Andrew Morton , Thomas Gleixner , "H. Peter Anvin" , Alexander van Heukelum Subject: Re: [git pull] generic bitops, take 2 In-Reply-To: <20080426151516.GA27894@elte.hu> Message-ID: References: <20080424215739.GA32378@elte.hu> <20080426151516.GA27894@elte.hu> User-Agent: Alpine 1.10 (LFD 962 2008-03-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 26 Apr 2008, Ingo Molnar wrote: > > i've added Alexander's patch that does the cleanup suggested by you Well.. Not really: > diff --git a/arch/um/Kconfig.x86_64 b/arch/um/Kconfig.x86_64 > index 3fbe69e..7a75043 100644 > --- a/arch/um/Kconfig.x86_64 > +++ b/arch/um/Kconfig.x86_64 > @@ -27,6 +27,14 @@ config SMP_BROKEN > bool > default y > > +config GENERIC_FIND_FIRST_BIT > + bool > + default y > + > +config GENERIC_FIND_NEXT_BIT > + bool > + default y > + It still declares this GENERIC_FIND_*_BIT thing separately for UM. Yes, that may _work_, but it's wrong to define it in two different places. It also makes me wonder why Kconfig.i386 can just include arch/x86/Kconfig.cpu, but x86_64 cannot? Linus