mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: "Björn Steinbrink" <B.Steinbrink@gmx.de>
Cc: Ingo Molnar <mingo@elte.hu>, Al Viro <viro@ZenIV.linux.org.uk>,
	Harvey Harrison <harvey.harrison@gmail.com>,
	"H. Peter Anvin" <hpa@zytor.com>,
	LKML <linux-kernel@vger.kernel.org>,
	"Pallipadi, Venkatesh" <venkatesh.pallipadi@intel.com>
Subject: Re: [PATCH] x86: !x & y typo in mtrr code
Date: Wed, 30 Apr 2008 09:46:11 +0200 (CEST)	[thread overview]
Message-ID: <alpine.LFD.1.10.0804300945150.6003@apollo.tec.linutronix.de> (raw)
In-Reply-To: <20080430064603.GA3602@atjola.homenet>

[-- Attachment #1: Type: TEXT/PLAIN, Size: 839 bytes --]

On Wed, 30 Apr 2008, Björn Steinbrink wrote:
> On 2008.04.29 23:04:35 +0200, Ingo Molnar wrote:
> > 
> > * Al Viro <viro@ZenIV.linux.org.uk> wrote:
> > 
> > > On Sat, Apr 26, 2008 at 09:00:17PM -0700, Harvey Harrison wrote:
> > > > As written, this can never be true.
> > > 
> > > ... and introduced through x86.git, of all things...  May I suggest 
> > > that in addition to all-important whitespace hunting something that 
> > > catches lowly real bugs would also be run over that tree?  sparse 
> > > *does* catch that...
> > 
> > firstly, it _was_ caught via Sparse, ...
> 
> But that is exactly Al's point. Had you run sparse over your tree
> _before_ it got pulled by Linus, that bug should have never made it into
> mainline.

sparse builds are on the way to the automated build framework
already. won't happen again.

Thanks,
	tglx

  reply	other threads:[~2008-04-30  7:46 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-27  4:00 Harvey Harrison
2008-04-27  4:20 ` Al Viro
2008-04-29 21:04   ` Ingo Molnar
2008-04-30  6:46     ` Björn Steinbrink
2008-04-30  7:46       ` Thomas Gleixner [this message]
2008-04-30  9:32       ` Ingo Molnar
2008-04-30 12:17         ` Björn Steinbrink
2008-04-30 12:35           ` Ingo Molnar
2008-04-30 15:35             ` Harvey Harrison
2008-04-30 18:06               ` Ingo Molnar
2008-05-06 18:24               ` Valdis.Kletnieks
2008-04-28 11:27 ` Ingo Molnar
2008-04-28 15:10   ` Harvey Harrison
2008-04-28 23:16 ` Pallipadi, Venkatesh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LFD.1.10.0804300945150.6003@apollo.tec.linutronix.de \
    --to=tglx@linutronix.de \
    --cc=B.Steinbrink@gmx.de \
    --cc=harvey.harrison@gmail.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=venkatesh.pallipadi@intel.com \
    --cc=viro@ZenIV.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome